Skip to content

fix: build against the released http-kit 0.8 crates - #202

Closed
lexoliu wants to merge 1 commit into
mainfrom
fix/201-http-kit-release
Closed

lexoliu wants to merge 1 commit into
mainfrom
fix/201-http-kit-release

Conversation

@lexoliu

@lexoliu lexoliu commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

zenwave moves from git dependencies on http-kit's main to the released crates: http-kit 0.8.0, http-kit-io 0.6.0, http-kit-h1 0.6.0, http-kit-tls 0.4.0, http-kit-h3 0.6.0.

main stopped building when Body::poll_frame_offering started taking Option<&mut PipeOffer> (zen-rs/http-kit#154). With None it is poll_next, so the native backend's poll_offering wrapper goes and both callers pass the consumer's offer straight through.

Checked: clippy with -D warnings on default features, native-compio,native-tokio,native-http3,native-kernel-tls, native-http3 alone, and wasm32-unknown-unknown.

Fixes #201

http-kit 0.8.0, http-kit-io 0.6.0, http-kit-h1 0.6.0, http-kit-tls 0.4.0
and http-kit-h3 0.6.0 carry everything the git dependencies on http-kit's
main were for. Body::poll_frame_offering now takes an optional offer and
is poll_next without one, so the native backend's poll_offering wrapper
goes.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lexoliu

lexoliu commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Duplicate of #200.

@lexoliu lexoliu closed this Nov 11, 2026
@lexoliu
lexoliu deleted the fix/201-http-kit-release branch November 11, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build against the released http-kit 0.8 crates

2 participants