Repository navigation
FE-2552: Fix previous release branch lookup to use natural version sort - #20
Merged
Merged
Conversation
`git branch -r --list | tail -1` sorted lexicographically, so `release/embed/2.9` ranked above `release/embed/2.12` and the new release branch was cut from a stale base commit. Switch to `--sort=-version:refname | head -1` so `2.12` wins over `2.9`.
gotbahn
marked this pull request as ready for review
May 14, 2026 21:25
gotbahn
changed the title
svbutko
approved these changes
May 15, 2026
dobladov
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled cut workflow in
zattoo/frontendcreatedrelease/embed/2.13from a stale commit because Cactus picked the wrong "previous" release branch. The lookup insrc/git.jsusedgit branch -r --list ... | tail -1, which sorts lexicographically — sorelease/embed/2.9ranked aboverelease/embed/2.12. The base commit then resolved tomerge-base(master, 2.9), miles behind master.Switching to
--sort=-version:refname | head -1uses git's built-in natural version sort (available since git 2.7), and2.12correctly outranks2.9.dist/index.jswas rebuilt withnpm run pack, andCHANGELOG.md+package.jsonwere bumped to5.0.1.The
v5branch needs to be advanced to this commit after merge so thezattoo/cactus@v5pin in consumer workflows picks the fix up.Tracked in FE-2557.