Make logging of unknown fields in OME metadata less severe - #75
Merged
normanrz merged 8 commits intoSep 8, 2026
Merged
Conversation
This warning fired e.g. when reading https://livingobjects.ebi.ac.uk/idr/zarr/v0.5/idr0033A/BR00109990_C2.zarr/0 Since, this log can actually be ignored, I propose to lower the severity of the log.
stefanhahmann
marked this pull request as ready for review
May 7, 2026 11:46
Member
|
Hmm. Why is it a problem that this is a warning? |
Contributor
Author
|
When using the library for reading datasets in FIJI a warning log brings the console to the front with some red message inside, giving the user the impression that something went wrong, which actually can be ignored. |
Member
|
Yeah that sounds reasonable. |
normanrz
reviewed
Sep 8, 2026
normanrz
reviewed
Sep 8, 2026
normanrz
approved these changes
Sep 8, 2026
Follow-up to the PR discussion: FINE hides the message entirely, while WARNING pops up the FIJI console in red. INFO keeps the notice visible without signalling an error. Also renames the handler (no longer warning-level) and updates the tests to capture INFO records, which fixes the failing build. Co-Authored-By: Claude Opus 5 <[email protected]>
Reverts the level back to FINE as originally proposed; the test now sets the logger level explicitly so the FINE records are still captured. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning fired e.g. when reading https://livingobjects.ebi.ac.uk/idr/zarr/v0.5/idr0033A/BR00109990_C2.zarr/0 Since, this log can actually be ignored, I propose to lower the severity of the log.