Repository navigation
fix(hub): a folder given in full matches one allowed with ~ (OFF-143) - #657
Merged
Merged
Conversation
A bridge allowed to start in ~/workspaces/Zalify refused a start in /Users/me/workspaces/Zalify: the Hub compared the folders as text. It now reads ~ as the machine's home on both sides; the node still checks real paths. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bridge allowed to start agents in
~/workspaces/Zalifyrefused a start in/Users/<me>/workspaces/Zalify("That folder isn't one this token may start in"): the Hub's check compared the folders as text. offdesk.so's AI teammates keep the folder in full, so handing a task to one failed.TokenAccess::allows_dir_at(cwd, home)reads~as the machine's home (from its registration) on both sides; with no home known it compares text as before. The node's real-path check (symlinks,..) is unchanged.Tests:
token_access_keeps_to_its_machines_and_folderscovers ~ against a full path both ways, a neighbour (notesy), another user's home,.., and no home known.🤖 Generated with Claude Code