Repository navigation
feat: author read filter takes a list of agents - #381
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A note read defaults to the caller's own notes and the shared notes. Another agent's notes come back only when the caller names that agent.
authorused to take one slug or"all", so a caller could not name two agents at once.authoronsearch_memory,list_notes,list_memory_duplicates, andread_entitytakes a list of slugs or"all". The MCP schema isarray of string | "all" | null.POST /searchtakesauthoras a list (a single slug string still resolves to one author).GET /notes,/admin/notes,/admin/duplicates, andPOST /admin/archivetake repeatedauthorparams.metadata->>'author' = ANY($n::text[]). The internal keyword isauthorsfromnote_scopedown tohistory_predicates.authordescription and the server instructions state the default scope and the explicit form,author=["natsume", "claude-code"].Related issues
Closes #380
Runtime evidence
search_memoryinput schema from an in-process MCP client:test_a_list_of_authors_reads_exactly_those_authorsagainst the throwaway Postgres and the live embedder: author C readsauthor=[A, B]throughGET /notesandPOST /searchand gets exactly A's and B's notes, not its own.The two full-run failures pass in isolation.
test_concurrent_appends_to_one_session_get_distinct_seqsfails the same way in a full run onmain(an asyncio lock bound to another event loop, order dependent); the other was a 503 from the live search endpoint and changes between runs.Verification
uv run pytestpasses (integration tests run locally against a throwaway Postgres container and the live embedder)uv run ruff format --check .anduv run ruff check .passdocker compose build mcppasses (Dockerfile / dependency changes) — N/A, no dependency changeChecklist (core principles)
doc_rowsand theturnslane.envskip-testslabel justified)