Repository navigation
스킬 마켓플레이스 작업 진행 표시 개선 - #328
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The scoped progress-state and UI changes preserve existing operation guards, with no unresolved blocking issues identified.
No open issues 🎉
What changed in this PR
This PR improves skill marketplace progress feedback by moving activity status into a shared panel visible across tabs.
Changes:
- Adds a themed progress ring and operation-specific messages that identify the target skill.
- Tracks concurrent catalog, local skill, and runtime operations while suppressing premature empty-list messages.
- Adds tests for progress bindings, completion order, failure, cancellation, and cleanup.
| File | Description |
|---|---|
| src/TableCloth.Test/SkillMarketplaceTests.Progress.cs | Adds progress UI and operation lifecycle tests. |
| src/TableCloth.App/ViewModels/SkillMarketplaceWindowViewModel.Runtimes.cs | Notifies shared busy state when runtime activity changes. |
| src/TableCloth.App/ViewModels/SkillMarketplaceWindowViewModel.cs | Adds shared progress state, targeted messages, and loading-aware empty states. |
| src/TableCloth.App/Dialogs/SkillMarketplaceWindow.axaml | Adds the shared progress panel and accessibility attributes; hides redundant status text. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
스킬 설치나 제거를 기다리는 동안 작업 안내가 설치된 스킬 탭에만 나타나고, 모든 작업에 공통 문구를 사용해 진행 상황을 구분하기 어려웠습니다. 카탈로그 로딩 중에는 빈 목록 안내도 표시했습니다.
창 상단에 공용 진행 패널을 추가했습니다. 제품 테마가 제공하는 진행 링과 함께 설치, 업데이트, 제거의 대상 스킬 이름을 표시합니다. 카탈로그와 설치 목록, 실행 환경 검사가 동시에 진행되면 각 작업 상태를 함께 표시하고 남은 작업이 끝날 때까지 패널을 유지합니다. 로딩 중에는 빈 목록 안내를 숨깁니다. 기존 중복 작업 방지와 탭 전환, 닫기 동작을 유지하고 상태 문구에 접근성 알림 속성을 추가했습니다.
검증 결과: