Repository navigation
fix(ci): pull MinIO from Chainguard and stop test mocks leaking - #407
Merged
Merged
Conversation
MinIO's own images on quay.io and Docker Hub now answer anonymous pulls with "unauthorized", so both integration jobs fail before a test runs and `docker compose up` cannot start local storage. Switch CI and the compose file to Chainguard's public MinIO build, which is the same server and ships with mc. CI pins the digest and creates the bucket with the server container's own mc, so no separate client image is needed. Compose runs it as root because the image defaults to a non-root user that cannot open volumes created by the old image. The web unit job failed for an unrelated reason. Two tests replaced react-i18next, react-router, and the workspace/auth contexts with partial stubs, and bun's mock.module keeps those stubs for every file that runs later in the process. On today's runners the notification SSR test runs early, so later files lost exports such as initReactI18next and useHasRole. Each stub now spreads the real module and overrides only what the test needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI is red on every PR right now for two unrelated reasons. Neither comes from a code change on
main.Integration jobs (
ts-integration,go-integration)quay.io/minio/minio,docker.io/minio/minio, and themcimages) now answer anonymous pulls withunauthorized.docker-compose.ymlnow use Chainguard's public MinIO build (cgr.dev/chainguard/minio). It is the same server and includesmc.docker exec minio-ci mc …, so no separate client image is needed.minio-inituses the same image, andminioruns as0:0: the image defaults to a non-root user that cannot open data volumes created by the old root-run image.ts-unitnotification-ssr-regression.test.tsandProtectedRoute.test.tsxreplacedreact-i18next,react-router, and the workspace/auth contexts with partial stubs. Bun'smock.modulekeeps a stub for every file that runs later in the same process.initReactI18next,useHasRole,Navigate).Testing
whatsapp-mediabucket created.minio+minio-initin an isolated project: healthcheck passes, and the bucket is created and set to private. MinIO starts on both a fresh volume and a root-owned one like existing local installs have.i18n,useRemoteHistory,MessageReply,ProtectedRoute): each fails onmainand passes on this branch.tsc -p apps/webis clean, andbiome lint apps/webis clean.