fix: spacing for blank links in header and footer - #1302
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
I think this is a false positive since props aren't being changed |
auto-screenshot-update: true
asanehisa
left a comment
asanehisa
left a comment
There was a problem hiding this comment.
i think we'll want a similar fix for the footer links
added in new commit |
nanhu95
changed the title
auto-screenshot-update: true
benlife5
left a comment
benlife5
left a comment
There was a problem hiding this comment.
Nit; don't duplicate "fix" in the title, just do
"fix: spacing for ..."
There was a problem hiding this comment.
I would put this file in the components/footer directory since it's footer-specific (but resolveLocalizedCtas makes sense here)
| import { type TranslatableCTA } from "../types/types.ts"; | ||
| import { resolveComponentData } from "./resolveComponentData.tsx"; | ||
|
|
||
| export type ResolvedCTA = Omit<TranslatableCTA, "label" | "link"> & { |
There was a problem hiding this comment.
I think this type might be equivalent to import { CTA as CTAType } from "@yext/pages-components";
| resolveLocalizedCtas, | ||
| } from "./resolveLocalizedCtas.ts"; | ||
|
|
||
| type FooterSection = { |
nanhu95
changed the title
4 participants
context: https://yext.slack.com/archives/C02UVSE7P6W/p1787940041327369
Updates the HeaderLinks component to not have inconsistent spacing when one or more of the links are blank. This is output straight from codex that I didn't review very closely, but appeared to work correctly when testing in platform dev mode.
Screen.Recording.2026-08-31.at.11.29.14.mov