Skip to content

Fix KV SLO failure propagation and data checks - #921

Draft
KirillKurdyukov wants to merge 6 commits into
mainfrom
fix/slo-kv-checks-20261014
Draft

KirillKurdyukov wants to merge 6 commits into
mainfrom
fix/slo-kv-checks-20261014

Conversation

@KirillKurdyukov

@KirillKurdyukov KirillKurdyukov commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Propagate unrecovered Table/Query worker errors to the process and SLO gate.
  • Check independently expected control generations and payloads after the
    existing SDK retry completes, including errors while consuming streams.
  • Keep control tables private to each process and clean them in the existing
    native workload.
  • Keep the original direct-exec entrypoint. Do not add a subprocess launcher,
    environment setup or a cleanup orchestrator to the SDK.

The additional entrypoint wrapper was removed in a separate corrective commit.
The native error, retry and control-data checks are unchanged by that removal.

Earlier SDK verification

  • The existing TestSloControlData cases passed: 3 passed.
  • pip check, sh -n tests/slo/docker-entrypoint.sh and git diff --check
    passed. The entrypoint content and executable mode match the original base.
  • Python 3.14 dependency deprecation warnings remain visible.

Hosted SLO/chaos acceptance is not claimed green. The previous head had failing
native jobs and queued async jobs; the corrective head requires its own CI.
Historical local adapter checks are not a substitute for ordinary Action CI.
Transactional concurrent RMW remains a separate change.

Current workload metric contract

Use only existing workload sdk.* counters and successful-operation latency Gauges. workload_type selects table (default), topic, or topic_tx; it does not select a metric format. No SDK convention instruments or native/legacy schema split are supported by this change.

Init pins Action PR81 at immutable d66bd1e10f893e5f70d542c4430a3cffb6d6f9f8. Table retains independently built current/baseline SDKs and requires successful read AND write observations for both refs. Topic requires read/write and Topic-tx transaction observations, including any supplied baseline. Existing actual scenario names, SDK source, metrics YAML, retries, deadlines, load, data checks and fatal process criteria are unchanged.

The selector/pin changes pass actionlint across all seven SDK workflows. Action has135/135 Linux tests, clean static checks/bundle, public exact-SHA verify, independent gate approval and real SDK/OTLP PASS/FAIL/INVALID evidence. These are not a claim that historical native SDK runtime failures were fixed or that new SDK CI is green.

All PRs remain draft; no merge, ready transition or v3 tag move. Default-branch publisher changes are not active merely because this branch was pushed.

Related migration PRs

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (d6391fb) to head (aa49c55).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   82.67%   82.69%   +0.01%     
==========================================
  Files          99       99              
  Lines       12961    12961              
  Branches     1269     1269              
==========================================
+ Hits        10716    10718       +2     
+ Misses       1794     1792       -2     
  Partials      451      451              
Flag Coverage Δ
integration 80.47% <ø> (+0.02%) ⬆️
unit 49.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

steps:
- name: Publish YDB SLO Report
uses: ydb-platform/ydb-slo-action/report@v2
uses: ydb-platform/ydb-slo-action/report@v3
@github-actions

Copy link
Copy Markdown

🌋 SLO Test Results

🔴 5 workload(s) tested — 3 workload(s) exceeded failure thresholds

Commit: 24fd126 · View run

Workload Thresholds Duration Report
sync-table 🟢 OK 10m 3s 📄 Report
sync-query 🔴 Failure 5m 59s 📄 Report
async-topic 🔴 Failure 6m 1s 📄 Report
async-query 🔴 Failure 10m 3s 📄 Report
sync-topic 🟢 OK 10m 7s 📄 Report

Threshold violations:


Generated by ydb-slo-action

@a-s-maslov

Copy link
Copy Markdown

Связанный issue: #936.

Для автоматического закрытия при влитии добавьте Fixes #936 в описание PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants