You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The reason will be displayed to describe this comment to others. Learn more.
Why not use mocks instead of 200 lines of “fake” objects? This code is copied directly from the SDK, so if the SDK implementation changes, these tests may no longer verify its actual behavior.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Active stream cursors can remain untracked and unreleased during connection shutdown, and a failed transactional stream can retain an unclosed response resource.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Active critical and moderate findings remain: async cleanup can skip rollback and resource release on cursor-close failure, while unwrapped cleanup errors can leak raw YDB exceptions and leave cursors running.
Sync stream close leaks raw errors and may leave cursor running
ydb_dbapi/cursors.py:669
Unlike the other public query paths, this new close() performs YDB operations (cancel, delete, and pool release) without handle_ydb_errors. A session cleanup failure therefore leaks a raw ydb.Error to callers instead of the DB-API error hierarchy, and can leave the cursor in running state because the final state cleanup is skipped. Translate cleanup errors while guaranteeing the cursor is unregistered and closed.
This issue also appears on line 1198 of the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a stream cursor, included a test for memory usage, and added a new configuration for actions.