Repository navigation
Add topic attributes to Reader metrics - #788
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
============================================
+ Coverage 75.95% 75.97% +0.02%
- Complexity 3841 3849 +8
============================================
Files 394 395 +1
Lines 17090 17123 +33
Branches 1810 1811 +1
============================================
+ Hits 12980 13010 +30
- Misses 3489 3493 +4
+ Partials 621 620 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alex268
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавляет атрибут topic к двум метрикам Reader:
topicPath хранится в существующем CommitOffsets внутри ReaderMetrics.partitions; обе метрики группируются по этой же map. ReadSession передаёт путь через существующий addPartition. Передача и захват Collection удалены; бизнес-логика коммитов и жизненный цикл партиций не меняются. При отсутствии партиций per-topic точки не публикуются.
Без topic остаются общие Reader-метрики received.bytes, local_buffer.messages, local_buffer.message_age.max, credit_balance_bytes и session.errors. Остальные topic-атрибуты Reader и Writer сохранены.
Проверено локально после удаления теста: 8 тестов ReaderMetricsTest/WriterMetricsTest, без failures/errors/skips; Checkstyle без нарушений. JDTLS недоступен; компиляция Maven успешна.