Repository navigation
Add endpoint and database attributes to Topic metrics - #786
Closed
KirillKurdyukov wants to merge 2 commits into
Closed
KirillKurdyukov wants to merge 2 commits into
KirillKurdyukov wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
============================================
- Coverage 75.95% 75.93% -0.02%
- Complexity 3838 3844 +6
============================================
Files 394 394
Lines 17090 17112 +22
Branches 1810 1812 +2
============================================
+ Hits 12980 12994 +14
- Misses 3488 3493 +5
- Partials 622 625 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KirillKurdyukov
marked this pull request as draft
October 26, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавляет endpoint (настроенный discovery host:port без схемы) и database во все метрики Topic Reader и Writer. Существующие атрибуты и бизнес-логика сохранены; общие ReaderSettings/WriterSettings не изменяются.
Тикет: https://st.yandex-team.ru/YDBAPPTEAM-1895
Контракт: https://wiki.yandex-team.ru/kikimr/developers/appteam/kb/observability-sdk/
Проверено: 173 теста (151 Topic + 22 Core), 0 ошибок/пропусков, Checkstyle без нарушений. 10 клиентских сценариев проверяют полные наборы атрибутов, ошибки и изоляцию одинаковых настроек между транспортами. Ручной прогон публичных клиентов через настоящий OpenTelemetry backend подтвердил атрибуты всех 24 инструментов; протокольные потоки замоканы, live YDB не запускался.