Skip to content

Add endpoint and database attributes to Topic metrics - #786

Closed
KirillKurdyukov wants to merge 2 commits into
masterfrom
topic-metric-endpoint-database
Closed

KirillKurdyukov wants to merge 2 commits into
masterfrom
topic-metric-endpoint-database

Conversation

@KirillKurdyukov

Copy link
Copy Markdown
Collaborator

Добавляет endpoint (настроенный discovery host:port без схемы) и database во все метрики Topic Reader и Writer. Существующие атрибуты и бизнес-логика сохранены; общие ReaderSettings/WriterSettings не изменяются.

Тикет: https://st.yandex-team.ru/YDBAPPTEAM-1895
Контракт: https://wiki.yandex-team.ru/kikimr/developers/appteam/kb/observability-sdk/

Проверено: 173 теста (151 Topic + 22 Core), 0 ошибок/пропусков, Checkstyle без нарушений. 10 клиентских сценариев проверяют полные наборы атрибутов, ошибки и изоляцию одинаковых настроек между транспортами. Ручной прогон публичных клиентов через настоящий OpenTelemetry backend подтвердил атрибуты всех 24 инструментов; протокольные потоки замоканы, live YDB не запускался.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.93%. Comparing base (5c43abd) to head (e85d22f).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
topic/src/main/java/tech/ydb/topic/TopicRpc.java 0.00% 2 Missing ⚠️
...n/java/tech/ydb/topic/read/impl/ReaderMetrics.java 83.33% 1 Missing and 1 partial ⚠️
...rc/main/java/tech/ydb/core/grpc/GrpcTransport.java 0.00% 1 Missing ⚠️
...ain/java/tech/ydb/core/impl/BaseGrpcTransport.java 0.00% 1 Missing ⚠️
.../java/tech/ydb/topic/write/impl/WriterMetrics.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #786      +/-   ##
============================================
- Coverage     75.95%   75.93%   -0.02%     
- Complexity     3838     3844       +6     
============================================
  Files           394      394              
  Lines         17090    17112      +22     
  Branches       1810     1812       +2     
============================================
+ Hits          12980    12994      +14     
- Misses         3488     3493       +5     
- Partials        622      625       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KirillKurdyukov
KirillKurdyukov marked this pull request as draft October 26, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant