Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 58.29% 58.29% -0.01%
==========================================
Files 294 294
Lines 34389 34389
==========================================
- Hits 20048 20047 -1
- Misses 14341 14342 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows MinGW builds require platform adaptations in imported utility code and standalone CMake settings. Generate compatibility copies under the build directory (mingw-compat/util), select Windows libc compatibility sources and system libraries, normalize root macros, and provide MinGW presets and dependency instructions. Reject OpenSSL 4.x, which is incompatible with the pinned gRPC.
All repository changes are confined to root CMake files, cmake/, and README.md. Imported util/, library/ (including YT), contrib/, and SDK source directories are untouched. CMake adapts eight utility files only in the build tree, redirects source/include/forced-include paths consistently, and exports build-interface include paths to SDK consumers. It rejects unexpected import changes and preserves generated file timestamps on unchanged configurations. The YT declaration ordering issue is handled with a compiler forced include. No MSVC changes remain.
Requires upstream PR ydb-platform/ydb#59557 and the normal import of those SDK-only source changes. They handle gRPC Windows header ordering and explicit generic path conversion in five examples; they were applied only in a disposable integration checkout for validation.
Validation on official SDK 3.27.0, base c1ac575, Windows x64 / MinGW-w64 GCC 16.2 / Release:
Validation covers the combined CMake and companion SDK source changes. MSVC, optional plugins, installation/packaging, and backend integration tests are outside this validation.