Repository navigation
Fix ODBC consumer compatibility and coverage - #694
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ODBC integration report✨ Open the interactive Allure report · 📦 Download the report bundle Commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ea2747613
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fixed both in c161059: reject parameter counts and |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
AI Review Summary
Verdict: ✅ No Critical or Major issues found
Critical and Major issues
No Critical or Major issues found.
Other findings
- Minor | Medium:
Datetime64is missing from the wide-temporal detection inMakeColumnMeta, so probe failures for Datetime64 params still surface asHYC00—odbc/src/utils/cursor.cpp:20 - Minor | Medium:
SQLNativeSqlunderAnsiSQL=1now returns the injected--!ansi_lexer/PRAGMA UnicodeLiterals;prefix as part of the native string, an undocumented contract change —odbc/src/connection.cpp:394 - Minor | Medium: descriptor
SQL_DESC_DISPLAY_SIZEcomputation lacks the unsigned (+1 digit) adjustment applied in theSQLColAttributepath —odbc/src/descriptor.cpp:176 - Minor | Medium: string lengths outside 0–32767 now fail with
HY000 "Too many parameters (maximum 32767)"instead of the previous behavior;length_erroris caught and mapped to a generic diagnostic —odbc/src/utils/escape.cpp:364 - Minor | Medium:
SQLSpecialColumnsnow discards all identifier rows when any primary-key column is missing or disallowed, instead of skipping only that column —odbc/src/statement_metadata.cpp:578 - Minor | Medium: no driver-level integration test exercises
AnsiSQL=1/PrepareSqlagainst a live server —odbc/src/connection.cpp:385 - Minor | Low: value overflows inside
ExecuteMultiaccumulateSQL_SUCCESSsilently, so a truncated total can mask per-set failures that reportedSQL_SUCCESS_WITH_INFO—odbc/src/statement.cpp:267 - Minor | Low:
ExtractAffectedRows's internal-index detection relies on a'/'-in-table-name prefix heuristic and may misclassify user tables whose names are dotted prefixes of other accessed tables —odbc/src/statement.cpp:39 - Minor | Low:
SQLGetFunctionsadvertises every ordinal in the ODBC 3.x ranges (1001–1021), including functions the driver does not export (e.g.SQLBrowseConnectat 1005) —odbc/src/metadata.cpp:134 - Minor | Low:
SQLGetFunctionscontinues to advertise legacy ODBC 2.x ordinal 6 (SQLColAttributes) alongside the 3.x name —odbc/src/metadata.cpp:134 - Nit | High: nanosecond fractions not divisible by 1000 are rejected with
22007; microsecond truncation would be friendlier —odbc/src/utils/convert.cpp:321 - Nit | Low:
GetCursorNamefabricatesSQL_CUR<address>, which is nondeterministic across runs —odbc/src/statement.cpp:998
This review was generated automatically. Critical and Major issues require attention; Minor and Nit findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
Finding outside the inline diffSeverity: Minor When Consider returning |
|
On row-count overflow: |
Fix ODBC metadata, value binding, chunked fetching and affected-row reporting. Add legacy statement allocation for unixODBC cursor-library compatibility.
Restore applicable consumer tests with YDB fixtures while keeping consumer implementations unchanged. Document reproduced upstream defects and unsupported behavior with exact exceptions.