Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟡 Changes recommended
Several documentation nits remain because the Node version guidance "24 or 26+" is ambiguous and could mislead readers, so the wording should be clarified (e.g., to specify even-numbered major releases only) across the cited local setup docs.
3 open issues
What changed in this PR
Updates local setup documentation to reflect the newer Node.js major versions required by the frontend/UI tooling, aligning these guides with the referenced upstream change.
Changes:
- Update the documented Node.js prerequisite from 20+ to 24 or 26+ in local setup docs (SLURM, Celery, frontend demo).
- Add guidance noting odd-numbered Node.js majors are not supported and refer readers to the UI repo’s
.nvmrcas the pinned default.
Review notes (nits):
- The phrasing “24 or 26+” can be read ambiguously (since “26+” includes odd majors like 27); consider stating the intended constraint directly (even-numbered majors only).
- References to the UI repo’s
.nvmrcwould be easier to follow if linked directly (prefer a branch-agnostic GitHub URL).
| File | Summary |
|---|---|
src/content/docs/local-setup/local-slurm.mdx |
Updates Node.js prerequisite wording in the SLURM local setup prerequisites list. |
src/content/docs/local-setup/local-frontend-demo.mdx |
Updates Node.js prerequisite wording in the frontend demo local setup prerequisites list. |
src/content/docs/local-setup/local-celery.mdx |
Updates Node.js prerequisite wording in the Celery local setup prerequisites list. |
Review effort: Balanced
|
|
||
| - **Python 3.9+** with [Poetry](https://python-poetry.org/docs/) installed | ||
| - **Node.js 20+** with npm | ||
| - **Node.js 24 or 26+** with npm (odd releases such as 25 are not supported). The default version is pinned in `.nvmrc` in the `ui` repo. |
| ## Prerequisites | ||
|
|
||
| - **Node.js 20+** with npm | ||
| - **Node.js 24 or 26+** with npm (odd releases such as 25 are not supported). The default version is pinned in `.nvmrc` in the `ui` repo. |
|
|
||
| - **Python 3.9+** with [Poetry](https://python-poetry.org/docs/) installed | ||
| - **Node.js 20+** with npm | ||
| - **Node.js 24 or 26+** with npm (odd releases such as 25 are not supported). The default version is pinned in `.nvmrc` in the `ui` repo. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Node.js prerequisite (frontend demo, Celery, SLURM) from "20+" to "24 or 26+", to match yaptide/ui#2465.