Propagate CancellationException in Flow/Suspend helpers; refine timeout handling and dispatcher default - #1
Closed
yangcyzhang wants to merge 1 commit into
Closed
yangcyzhang wants to merge 1 commit into
yangcyzhang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CancellationExceptionis never swallowed by Flow helpers so coroutine cancellation and structured concurrency remain correct.withTimeoutOrDefaultso outer-scope cancellations propagate.maindispatcher toDispatchers.Defaultand update docs for renamed callback helper.Description
CancellationExceptioninonEachCatching,flatMapLatestCatching, andmapNotNullCatchingwhile still swallowing other exceptions.withTimeoutOrDefaultto catchTimeoutCancellationExceptionspecifically so parent cancellations are propagated.CoroutineKitDispatchers.maindefault toDispatchers.Defaultfor JVM support.callbackToFlow(renamed helper) and adjusted docs accordingly.CancellationExceptionpropagation foronEachCatching,mapNotNullCatching,flatMapLatestCatching, and parent-cancellation behavior forwithTimeoutOrDefault.Testing
./gradlew :coroutinekit:testand all tests (including new tests inFlowExtTestandSuspendExtTest) passed.CancellationExceptionis propagated for Flow helpers and thatwithTimeoutOrDefaultdoes not return the fallback when the parent coroutine is cancelled, and they succeeded.Codex Task