Run XLSX tests in CI - #200
Merged
Merged
Conversation
Related to yakew7#199
Contributor
|
@ahmdkaml is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
Author
|
There is no disccusion section here but, I wanted to ask how r u doing |
Owner
|
im doing good wbu? |
Collaborator
Author
|
fine, thought that there is a better channel for communication though |
Owner
|
im gonna make one i forgot too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR updates the profiler CI job to explicitly install the optional Excel dependency:
pip install -e ".[excel]" pytest
This ensures the XLSX tests guarded by @requires_openpyxl actually run in CI instead of being silently skipped when openpyxl is unavailable.
XLSX support remains optional for local development, while CI now exercises the XLSX test coverage and fails if those tests break.
Closes #199.