Core module split - #26
Open
juicycleff wants to merge 2 commits into
Open
Conversation
EngineOption named *fabriq.Fabriq to look the facade up in the container. That one type parameter pulled in fabriq's composition root and every adapter it wires, so a package whose entire use of fabriq is f.Vector() was linking ClickHouse, Elasticsearch, pgx, go-redis and Trove. Injecting core/query.Fabric instead takes the build graph from 1418 packages to 254 and clears all of those drivers out. go.sum loses 92 lines with it. It also means an engine reached over the wire drops straight in. A deployment registers *remote.Fabric under the same port key and nothing here changes. The replace directive is local dev. Repin to a released fabriq and drop it before this merges.
Weave uses the query port and a handful of fakes. Requiring the root module pulled fabriq's entire go.mod into resolution, so every driver it names sat in our go.sum regardless. The replace is local development only. Repin to a tagged fabriq/core and drop it before this merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.