ci(release): drop removed extensions from every release surface - #67
Merged
Conversation
The previous commit trimmed the EXTENSIONS array that "all" mode tags, but that was one of four lists naming these modules. The other three still had them: The workflow_dispatch module dropdown offered ai, cron, database, gateway and storage as release targets. Picking one would resolve a module path with no go.mod behind it. release-please-config.json declared all five as packages, and .release-please-manifest.json pinned each at 0.1.0, so release-please was tracking versions for directories that hold a single README. Cron and storage were in all four lists too, which is why the versioning has been quietly producing extensions/cron tags since they were removed. Both come off with the rest. The dispatch options and the EXTENSIONS array now hold the same 18 names, and the release-please config and manifest agree with each other.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Conventional Commits ValidationPR Title: valid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit was written for #65 and missed the merge. #65 went in as
bea3f3d8, whose parents are60ca6731and7715de1e, so it merged thebranch at two commits. The third landed afterwards and has been sitting on
refactor/remove-deprecated-extensionsunmerged ever since. This carries itonto main unchanged.
The visible symptom is the release workflow's Run workflow dialog, which still
offers ai, cron, database, gateway and storage as release targets. Picking one
resolves a module path with no go.mod behind it.
What #65 did and did not fix
Four separate lists named these modules. #65 landed the fix for one:
EXTENSIONSarray that "all" mode tagsworkflow_dispatchdropdownrelease-please-config.jsonpackages.release-please-manifest.jsonCron and storage were in all four too, which is why versioning has been
quietly minting
extensions/cron/vX.Y.Zagainst a directory holding oneREADME ever since they were removed.
After this
The dropdown and the
EXTENSIONSarray hold the same 18 names, and therelease-please config and manifest hold matching keys. Every package
release-please tracks now has a real go.mod behind it, which became true for
auth when #66 restored its module.
Three files, 40 deletions, no insertions.