fix: ran go fix - #46
Merged
Merged
Conversation
Two failures blocked the go fix commit. `go fix` inlined every call site of intPtr, which carries a `//go:fix inline` directive, and left the function itself behind for golangci-lint to flag as unused. Removing it is the intended last step of that rewrite. The intPtr functions in plugins/* and settings/ are separate per-package copies and still have callers, so they stay. The Security job was already failing on main before this branch: govulncheck found 7 standard-library advisories (GO-2026-5026, -5972, -6088..-6091, -6218), all fixed in Go 1.26.6. CI asked for '1.26', which setup-go resolved against the runner's toolcache to the older 1.26.5. Pin the patch instead.
Pinning 1.26.6 renamed the matrix job to 'ci / Test (ubuntu-latest, go1.26.6)', which the branch ruleset does not require, so the required 'ci / Test (ubuntu-latest, go1.26)' could never report and the PR stayed blocked. Overriding only primary-go-version has its own cost: the coverage step compares the primary against matrix.go-version, so a value outside the matrix silently stops coverage uploads. xraph/workflows v1.15.0 sets check-latest on setup-go instead, so a bare minor resolves to the newest patch. The govulncheck failures are fixed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical
go fixcleanup across the engine and its tests. No behaviour change.Routed through a PR rather than pushed straight to
main, which the branch ruleset declines on two counts: the commit is unsigned, and required status checks only run on a pull request. Merging here satisfies both, since GitHub signs the squash commit with its own key.