Repository navigation
test(feed): regression for backtick identifiers containing quotes - #593
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
Adds a MySQL Syntax.Backticks case for xo#587: an identifier such as `we'ird` must not open a phantom string, or the following literal's \\ escapes collapse before the server sees them. The transit grammar already honors Backticks; this locks the behavior in. Disclosure: drafted with Grok assistance; I reviewed and tested the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression coverage for #587.
With MySQL
Syntax.Backticks, an identifier such as`we'ird`must be one quoted span. Without backticks, the embedded'opens a phantom string and later\\escapes in the next literal are mishandled. The transit grammar already honorsBackticksfor MySQL via dbmeta; this locks the behavior infeed.Test plan
go test ./feed/ -run TestBacktickIdentifierWithQuoteKeepsStringEscapes -count=1go test ./feed/ -count=1AI disclosure
Drafted with assistance from Grok; I reviewed and ran the tests locally.