Repository navigation
docs(security): drop fixed items from sandbox review follow-ups - #680
Merged
Merged
Conversation
Updated the recommended follow-ups for sandbox security review, including changes to the order and wording of items.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The "Recommended follow-ups" list in docs/security/sandbox-security-review.md still listed two items that are already fixed, and its numbering skipped 6.
secret_refs) was fixed in fix(sandbox): scope secret_refs to the session tenant #677.AutomountServiceAccountToken: falsefix landed in fix(sandbox): do not mount a ServiceAccount token in sandbox pods #678.This PR removes those two done items, renumbers the remaining list, and notes the as-of state (#679). The remaining open items (F8 loopback credential, F11 explicit signing secret, per-tenant snapshots, optional seccomp) are unchanged.
Docs only, no code changes.