Skip to content

test(wxt): assert offline-check failures instead of logging them - #2694

Merged
nishu-murmu merged 2 commits into
wxt-dev:mainfrom
suveshmoza:test/offline-check-logs
Oct 26, 2026
Merged

nishu-murmu merged 2 commits into
wxt-dev:mainfrom
suveshmoza:test/offline-check-logs

Conversation

@suveshmoza

Copy link
Copy Markdown
Contributor

Overview

The DNS timeout and DNS throw tests call consola.error, so those expected failures showed up in the test output. Mocked consola and asserted the two calls instead.

Manual Testing

cd packages/wxt
bun run test run src/internal-utils/__tests__/network-utils.test.ts
Screenshot 2026-10-26 at 02 20 13

Related Issue

This PR closes #2692

@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 60956df
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6adf1be5d809e94d0dc96395
😎 Deploy Preview https://deploy-preview-2694--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1c1cbded-3354-41ba-a458-b5cba76f6871

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Oct 25, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2694

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2694

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2694

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2694

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2694

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2694

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2694

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2694

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2694

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2694

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2694

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2694

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2694

wxt

npm i https://pkg.pr.new/wxt@2694

commit: 60956df

@nishu-murmu nishu-murmu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.26%. Comparing base (f0568da) to head (60956df).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
- Coverage   80.40%   80.26%   -0.15%     
==========================================
  Files         139      139              
  Lines        4160     4160              
  Branches      959      959              
==========================================
- Hits         3345     3339       -6     
- Misses        718      722       +4     
- Partials       97       99       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nishu-murmu
nishu-murmu merged commit 71bac2a into wxt-dev:main Oct 26, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for helping make WXT better!

@PatrykKuniczak

PatrykKuniczak commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

@suveshmoza @nishu-murmu That's not a test, that should be named chore.
@fkatsuhiro Let's read it also, this can be helpful for you.

We've been using chore, feat,fix, docs mainly.
If you don't adding new feature and that's not a fix, for a bug, which affecting our users.
Then use chore and in the () specify it if it's necessary.

This should be named chore(ci) IMO, but Aaron will change in manually during release.
There's no test section in releases, let's go through and see which names @aklinker1 use.

If i'm not right, let's Aaron correct me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Error checking offline status during workflows run

3 participants