Repository navigation
test(wxt): assert offline-check failures instead of logging them - #2694
Conversation
Signed-off-by: Suvesh Moza <[email protected]>
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
- Coverage 80.40% 80.26% -0.15%
==========================================
Files 139 139
Lines 4160 4160
Branches 959 959
==========================================
- Hits 3345 3339 -6
- Misses 718 722 +4
- Partials 97 99 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for helping make WXT better! |
|
@suveshmoza @nishu-murmu That's not a We've been using This should be named If i'm not right, let's Aaron correct me. |
Overview
The DNS timeout and DNS throw tests call
consola.error, so those expected failures showed up in the test output. Mockedconsolaand asserted the two calls instead.Manual Testing
Related Issue
This PR closes #2692