Repository navigation
fix: script and test Lows batched on #399 - #527
Merged
Merged
Conversation
Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
A base such as --output=f made git write the diff to a file and read as an empty, ordinary change. Add --end-of-options and tests for it and for the unknown-revision fail-closed path. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Assert the exact refusal messages, keep status-0..5 and log no Status rewrite in the legacy Ready to push test, and share the Status loop. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
It left a gittest-home-* directory in TMPDIR on every call. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Owner
Author
|
Opus review CLEAR on 6e9dac1. Five mutations each fail the matching test; full go test ./..., make check-ci and go test ./scripts/ under /bin/bash 3.2 exit 0. Low (batched on #399): scripts/review_class_test.go:101 checks for a file named leak, git would write leak...topic; glob leak*. Unverified: Linux runners, a live board. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the scripts, Makefile and test Lows from #399:
scripts/hugo.shsurvives an empty array under macOS bash 3.2 (fixes TestHugoRefusesAssetWithWrongChecksum with /bin/bash first in PATH).scripts/review-class.shreads its base as a revision (--end-of-options); an unknown base fails closed.actionlintin.PHONY, stale install comment dropped.Bash(git pushallow rule must be a topic-branch allow; board move refusals and the Status option IDs are pinned; the board git helper no longer leaks a temp home.Refs: #399
Review: Opus CLEAR on 6e9dac1 (five mutations each fail the matching test; full go test ./..., make check-ci and the scripts tests under bash 3.2 exit 0). Low (batched on #399): scripts/review_class_test.go:101 looks for a file named
leakbut git would writeleak...topic; globleak*. Unverified: Linux runners, a live board.🤖 Generated with Claude Code