Repository navigation
fix: Go-side Lows batched on #399 - #526
Merged
Merged
Conversation
A loopback http:// name is accepted only from --public-url (a test double); a configuration value goes through NormalizePublicURL like config.Load and the doctor. A non-string public_url no longer fails ReadClientConfig for every client command, and the tailscale serve hint prints only for an all-digit port. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
The fix runs sudo commands but previews none, so a non-admin was asked "Ready to run this?" first. Also test that an owner or mode change during the confirm runs nothing. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
A mutation of the len(admin) > 0 branch survived because the Fail loop exits non-zero anyway; assert the administrator message. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
workspaceVolumes printed roots and df paths raw; escape them like the other steps. Also pin that the three roots steps use needsRoots. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Load used os.Open, so a FIFO named as the configuration hung the process; open with O_NONBLOCK as the secret reader does. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
The setup commands already carry --prefix; the doctor's fix lines aimed at /opt/whr for a user with another prefix. Goldens updated. Refs: #399 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Owner
Author
|
Opus review CLEAR on 27e36f4. Eight mutations each fail the matching test; full go test ./... and make check-ci exit 0 (author and reviewer). Lows (batched on #399): isDigits untested and a named port prints the funnel line without a command; a setup-report path in one test is not sandboxed. Unverified: live whr github app create, real Tailscale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Go-side Lows from #399 (each with a test that failed first):
whr github app createrefuses a loopbackhttp://public_url from the config (command, doctor public-url step and config.Load agree); a non-string public_url no longer breaks every client command; thetailscale servehint prints only for an all-digit port.config.Loadopens with O_NONBLOCK so a FIFO path cannot hang.--prefixthat was given (golden files change only by that flag); unused dscl stub and a help example removed.Refs: #399
Review: Opus CLEAR on 27e36f4 (8 mutations each fail the matching test; full go test ./... and make check-ci exit 0). Lows (batched on #399): isDigits is untested and a named port prints the funnel line without a command; a setup-report path in one test is not sandboxed. Unverified: a live
whr github app create, real Tailscale, outside readers of the longer doctor fix strings.🤖 Generated with Claude Code