Repository navigation
build: pass -trimpath to all go commands in make targets - #467
Merged
Merged
Conversation
Keeps any GOFLAGS from the environment or go env and adds -trimpath once. The source-install test fixtures' fake go now delegates go env to the real go. Refs: #466 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Refs: #466 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Owner
Author
|
Review evidence: Opus CLEAR on 409b1e0, no blocking findings. Opus tested GOFLAGS cases (existing -mod=mod, -trimpath already present, recursive make, unset/empty). First full go test hung because the fake go in scripts/install_test.go looped on go env; fixed, assertions unchanged. 54 packages ok (two invocations, private cache); go test ./scripts not rerun on the final tip; make check-local passes. Lows in #399: leading space in GOFLAGS when both empty; make GOFLAGS=... overrides; branch base behind main (GitHub rebases on merge). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makefile keeps an existing GOFLAGS (environment, else go env GOFLAGS) and adds -trimpath once, so worktrees share the Go build cache (measured: second path adds 44 MB without it, 0 MB with it). scripts/install_test.go fake go hands env to the real go. One line in .agents/code.md on the shared cache and a private GOCACHE for heavy runs. Full go test ./... evidence: 54 packages ok in two invocations on a private cache; no test depends on absolute source paths. ci.yml and release.yml unchanged (goreleaser already sets -trimpath). Opus CLEAR on 409b1e0. Branch base is behind main; GitHub rebases on merge.
Closes #466
🤖 Generated with Claude Code