Skip to content

perf(publication): consolidate resumable PR bookkeeping - #928

Merged
thewrz merged 15 commits into
mainfrom
fix/issue-908
Sep 25, 2026
Merged

thewrz merged 15 commits into
mainfrom
fix/issue-908

Conversation

@thewrz

@thewrz thewrz commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

This was written agentically; verify its assertions:

Why

Per-PR publication required repeated root calls for body composition, creation, registration, board movement, receipt publication, and summary updates. Interrupted calls could duplicate writes or resume with stale identity.

What

Add one resumable call per publication stage. pr-stage.sh open composes the four approved sections, creates or uniquely recovers the intended draft, records the PR, and moves its issue to In review. finalize consumes fresh final evidence, publishes/classifies the receipt, and records the summary. It launches no tests, fixes, or reviews.

Saved intent binds the target, actual head, title, body, and pre-existing PRs; a lost create response cannot adopt an unrelated draft. Completion is bound to the final head and original review input. The primary run repository remains distinct from the PR checkout. Restored auto-review behavior is retained.

The PR targets fix/issue-909 (#923). Initial integration baseline 1b0a9d85e59ec5145ce2db5084593d206fbd5cb4 contains initial #902/#909 and inherited #907. The adversarial review uses that complete baseline; finalized parent repairs are integrated in f1d84fabb936e95b00f75bebaec984034bad563f, which passed the canonical full suite and final-head CI.

Testing

  • Failing boundary regressions before implementation; pr-stage 63/63, post-receipt 245/245, run-state-summary 47/47, dispatch 816/816, plus invocation/safety/size contracts and generated-plugin rebuild.
  • AGENT_TEST_JOBS=8 AGENT_TEST_TIMEOUT_SCALE=2 tests/run-tests.sh on clean 7b532e36644fc74d05b05b15599090644fa59595: exit 0, ALL GREEN; remote matches. Earlier failed compatibility checks are retained separately.
  • One adversarial review and findings disposition.
  • Final parent integration and final-head GitHub CI.

Closes #908

🤖 Co-authored by Codex.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: d114726f-c11c-45a1-b5c4-e03e7fcbceca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

mergetest and others added 3 commits September 24, 2026 21:42
…e-908

# Conflicts:
#	agentkit/skills/parallel-issues/SKILL.md
#	tests/lint-helper-size.sh
#	tests/lint-skill-size.sh
#	tests/test-parallel-dispatch-contract.sh
#	tests/test-skill-size.sh
…e-908

# Conflicts:
#	agentkit/skills/parallel-issues/references/worker-prompts.md
#	tests/lint-helper-size.sh
#	tests/lint-skill-size.sh
#	tests/test-parallel-dispatch-contract.sh
#	tests/test-skill-size.sh
@thewrz

thewrz commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

One authorized adversarial review completed using Anthropic Claude claude-opus-5, effort xhigh, with tools disabled. No second review was sent after repairs.

Immutable input: complete integration base 1b0a9d85e59ec5145ce2db5084593d206fbd5cb4, reviewed head 7b532e36644fc74d05b05b15599090644fa59595, diff SHA-256 067c16a380fc888b7880bfe81a99f7656ba544617271334c733f9dfd652f9998. Final integrated head: f1d84fabb936e95b00f75bebaec984034bad563f.

Findings disposition:

  • F1 fixed: the documented disclosure preparation is idempotent, so retrying the actual publication recipe preserves the saved body intent.
  • F2 corrected with a narrower safe contract: an explicit pre-invocation not-attempted outcome permits retry. The outcome becomes uncertain before invoking gh and remains uncertain on raw transport failure. A fresh empty listing is not proof of absence; that suggested shortcut was declined. A read-only audit found several post-create paths that can return no JSON, so empty output also never proves absence. The outcome path is restricted to the selected run and issue-specific artifact, and stale evidence is reset before each call.
  • F3 fixed: every nonzero create result carrying a PR identity records the failure and stops before registration/board completion, regardless of closing-reference state.
  • F4 fixed for supported legacy records: noncanonical records may omit payload; canonical records still require it. Parsing preserves an empty payload alongside model-substitution provenance.

Finalized #902 and #909/#907 are integrated. Focused pr-stage 87/87, gh-body 207/207, post-receipt 250/250, PR-state 194/194, receipt 89/89, run-state 121/121 and summary 47/47, plus review/dispatch/invocation/size contracts and generated build passed. AGENT_TEST_JOBS=8 AGENT_TEST_TIMEOUT_SCALE=2 tests/run-tests.sh passed on the clean final head: exit 0, ALL GREEN. Log /tmp/issue-908-full-f1d84fa.log, SHA-256 c526e0d4cff6c7a2bb0d5d4c790906a8ca3723427cbc7a60572685ffa49566e6. Required final-head CI, all four suite shards, and aggregate gates are green. The PR remains draft.

mergetest and others added 7 commits September 24, 2026 23:01
Preserve both contracts using the previously verified integration resolution.

Co-Authored-By: Codex <[email protected]>
The file tree is unchanged; retain its measured size limits while carrying the predecessor landing corrections.

Co-Authored-By: Codex <[email protected]>
Keep commit versus push, before-dispatch targets, and live reviewer/test evidence explicit while preserving the measured prose reduction.

Co-Authored-By: Codex <[email protected]>
Preserve every execution, recovery, and baseline-exclusion rule while lowering the inherited reference-size limit.

Co-Authored-By: Codex <[email protected]>
Retain the identical candidate tree and all predecessor corrections.

Co-Authored-By: Codex <[email protected]>
Carry the #929 test synchronization repair through the remaining sprint stack; production files unchanged.

Co-Authored-By: Codex <[email protected]>
@thewrz
thewrz changed the base branch from fix/issue-909 to main September 25, 2026 06:34
@thewrz
thewrz marked this pull request as ready for review September 25, 2026 06:37
@thewrz
thewrz merged commit 220e702 into main Sep 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(publication): consolidate PR bookkeeping behind one resumable command

2 participants