fix(release): keep Cargo.lock synchronized on version bumps - #161
Merged
Conversation
Teakowa
marked this pull request as ready for review
August 17, 2026 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cargo metadata --locked;Cargo.lockstate and immediately verify that locked metadata succeeds;Cargo.lockin the automated release version commit.Why
The direct
maincommite89e725implemented most of #160 (committedCargo.lock, locked CI/release gates, and benchmark binary reuse), but the release-tag workflow still changedCargo.tomlwithout updating or stagingCargo.lock. The next automated version bump could therefore create a tag whose release workflow fails under--locked.Validation
mainaftere89e725;.github/workflows/release-tag.yml;cargo metadata --lockedbefore committing.Fixes #160