Skip to content

fix(release): preserve version across jobs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Teakowa merged 1 commit into from
Aug 17, 2026
Merged

fix(release): preserve version across jobs #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ jobs:

build:
name: Build ${{ matrix.target }}
needs: prepare
needs: [plan, prepare]
strategy:
fail-fast: false
matrix:
Expand All @@ -207,7 +207,7 @@ jobs:
steps:
- uses: actions/checkout@v7
with:
ref: ${{ needs.prepare.commit }}
ref: ${{ needs.prepare.outputs.commit }}

- name: Install Linux cross linker
if: matrix.target == 'aarch64-unknown-linux-gnu'
Expand Down Expand Up @@ -238,10 +238,14 @@ jobs:
- name: Package Unix artifact
if: runner.os != 'Windows'
env:
VERSION: ${{ needs.prepare.version }}
VERSION: ${{ needs.plan.outputs.version }}
TARGET: ${{ matrix.target }}
run: |
set -euo pipefail
[[ -n "${VERSION}" ]] || {
echo 'release version is empty; refusing to create an unversioned artifact.' >&2
exit 1
}
mkdir -p dist/workshop-rs-cli-${VERSION}-${TARGET}
cp "target/${TARGET}/release/workshop-rs-cli" "dist/workshop-rs-cli-${VERSION}-${TARGET}/"
tar -C dist -czf "workshop-rs-cli-${VERSION}-${TARGET}.tar.gz" "workshop-rs-cli-${VERSION}-${TARGET}"
Expand All @@ -250,9 +254,12 @@ jobs:
if: runner.os == 'Windows'
shell: pwsh
env:
VERSION: ${{ needs.prepare.version }}
VERSION: ${{ needs.plan.outputs.version }}
TARGET: ${{ matrix.target }}
run: |
if ([string]::IsNullOrWhiteSpace($env:VERSION)) {
throw 'release version is empty; refusing to create an unversioned artifact.'
}
$directory = "workshop-rs-cli-$env:VERSION-$env:TARGET"
New-Item -ItemType Directory -Path "dist/$directory" | Out-Null
Copy-Item "target/$env:TARGET/release/workshop-rs-cli.exe" "dist/$directory/"
Expand All @@ -269,13 +276,13 @@ jobs:

publish:
name: Publish crates
needs: prepare
needs: [plan, prepare]
runs-on: ubuntu-latest
environment: release
steps:
- uses: actions/checkout@v7
with:
ref: ${{ needs.prepare.commit }}
ref: ${{ needs.prepare.outputs.commit }}

- name: Install stable toolchain
uses: dtolnay/rust-toolchain@master
Expand All @@ -285,14 +292,18 @@ jobs:
- name: Publish library then CLI
env:
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
VERSION: ${{ needs.prepare.version }}
VERSION: ${{ needs.plan.outputs.version }}
shell: bash
run: |
set -euo pipefail
[[ -n "${CARGO_REGISTRY_TOKEN}" ]] || {
echo 'CARGO_REGISTRY_TOKEN is not configured in the release environment.' >&2
exit 1
}
[[ -n "${VERSION}" ]] || {
echo 'release version is empty; refusing to publish.' >&2
exit 1
}

published() {
curl --fail --silent --show-error -A "workshop-rs-release/${VERSION}" "https://crates.io/api/v1/crates/$1/${VERSION}" >/dev/null
Expand Down Expand Up @@ -324,14 +335,14 @@ jobs:

release:
name: Assemble GitHub Release
needs: [prepare, build, publish]
needs: [plan, prepare, build, publish]
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v7
with:
ref: ${{ needs.prepare.commit }}
ref: ${{ needs.prepare.outputs.commit }}
fetch-depth: 0

- name: Install stable toolchain
Expand All @@ -348,10 +359,14 @@ jobs:

- name: Generate checksums and catalog notes
env:
VERSION: ${{ needs.prepare.version }}
COMMIT: ${{ needs.prepare.commit }}
VERSION: ${{ needs.plan.outputs.version }}
COMMIT: ${{ needs.prepare.outputs.commit }}
run: |
set -euo pipefail
[[ -n "${VERSION}" ]] || {
echo 'release version is empty; refusing to assemble a release.' >&2
exit 1
}
cd dist
sha256sum *.tar.gz *.zip > SHA256SUMS.txt
cd ..
Expand All @@ -373,8 +388,8 @@ jobs:
- name: Create or resume a draft release
env:
GH_TOKEN: ${{ github.token }}
TAG: v${{ needs.prepare.version }}
COMMIT: ${{ needs.prepare.commit }}
TAG: v${{ needs.plan.outputs.version }}
COMMIT: ${{ needs.prepare.outputs.commit }}
run: |
set -euo pipefail
if ! gh release view "${TAG}" >/dev/null 2>&1; then
Expand All @@ -390,13 +405,13 @@ jobs:
- name: Upload artifacts and checksums
env:
GH_TOKEN: ${{ github.token }}
TAG: v${{ needs.prepare.version }}
TAG: v${{ needs.plan.outputs.version }}
run: gh release upload "${TAG}" dist/* --clobber

- name: Publish the completed GitHub Release
env:
GH_TOKEN: ${{ github.token }}
TAG: v${{ needs.prepare.version }}
TAG: v${{ needs.plan.outputs.version }}
run: |
set -euo pipefail
if [[ "$(gh release view "${TAG}" --json isDraft --jq .isDraft)" == "true" ]]; then
Expand Down