feat(wir): add canonical rule event surface - #13
Merged
Conversation
Teakowa
marked this pull request as ready for review
August 17, 2026 11:31
Contributor
Author
|
Consumer verification is complete against the pushed PR head
The consumer accepts legacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the canonical Workshop WIR/event surface required by del-rs#8.
Event::EachPlayervariant as the legacy/default representation ofEachPlayerWithFilters { team: All, target: All }.Event::EachPlayeras the canonical filtered Workshop event with explicitAll/Allfilters.EachPlayerand explicitEachPlayerWithFilters(All, All)across supporteden-USandzh-CNemission and reparsing.d854bf01fc7bbf3b2169f67408c07a8da8989ad6: 366/366 exact matches, 0 exclusions.Closes #12.
Validation
Workshop-rs:
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targetscargo test -p workshop-rs --test rule_events— 6/6 passedcargo run -p workshop-rs --bin workshop-catalog-gen -- check48b3a07188f7137a8a81e51fc33c06681da5ca5d30b79ee636b0147eb14dfc6d1.85.0.Current Wright consumer verification:
workshop-rsto this PR head3b9a9b6b5ce70921c466268522272abad8aaee34.cargo fmt --all --checkpassed.cargo clippy --locked --workspace --all-targets --all-features -- -D warningspassed.cargo test --locked --workspace --all-targets --all-featurespassed.cargo build --locked --release -p wright-cli -p wright-lsp -p wright-benchpassed.python3 scripts/v1-gates.py --wright target/release/wrightpassed: 6/6.python3 scripts/run-scenarios.py --wright target/release/wrightpassed: 7/7, including the each-playerAll/Allevent scenario.target/release/wright-benchpassed.No DEL/OSTW-specific types or provider-local event encoding are added.
workshop-rsremains the sole canonical Workshop event owner.