Skip to content

feat: establish the workshop-rs catalog provider seam - #34

Merged
Teakowa merged 19 commits into
mainfrom
feat/del-rs-29-workshop-provider
Aug 18, 2026
Merged

feat: establish the workshop-rs catalog provider seam#34
Teakowa merged 19 commits into
mainfrom
feat/del-rs-29-workshop-provider

Conversation

@Teakowa

@Teakowa Teakowa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Consumes the released workshop-rs 0.1.1 crate from crates.io and raises the MSRV to Rust 1.85.
  • Adds the del-rs-owned CatalogProvider backed only by canonical workshop-rs catalog APIs.
  • Resolves ExternalPosition::Type enum domains through Catalog::enum_domain, returning canonical ExternalTypeInfo without querying Kind::Enum entries.
  • Preserves direct value/action canonical IDs and catalog parameter metadata, including parameter names and optional/default status; NoopProvider remains available.
  • Adds WorkshopSourceBridge, a source-only DEL-owned bridge from SourceMap files and byte spans to a workshop-rs SourceFile arena plus typed FileId/1-based Position/Span.
  • Documents del-rs Lower core DEL HIR into canonical workshop-rs WIR #30 as the DEL-owned HIR-to-WIR lowering adapter; canonical WIR/catalog/emission contracts remain owned by workshop-rs. No copied catalog data or backend encoding is added here.

Evidence

  • cargo build --locked --all-targets
  • cargo test --locked --all-targets
  • cargo test --locked --test workshop_provider --test matrix --test corpus
  • provider tests: 8 passed, including Team enum type, direct Add value identity/parameters, and SmallMessage optional/default metadata
  • source-bridge tests: 3 passed, covering cross-file typed identity, Unicode scalar columns, 1-based line/newline/EOF boundaries, and explicit invalid-location errors
  • cargo metadata --locked and cargo tree --locked: registry workshop-rs v0.1.1
  • changed-file rustfmt checks and git diff --check
  • GitHub Actions test passed for commit 0d9db8b

Closes #29
Parent: #8
Canonical event contract: workshop-rs#12, shipped in workshop-rs 0.1.1.

@Teakowa
Teakowa marked this pull request as ready for review August 18, 2026 04:12
@Teakowa
Teakowa merged commit bbdc69c into main Aug 18, 2026
1 check passed
@Teakowa
Teakowa deleted the feat/del-rs-29-workshop-provider branch August 18, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Establish the workshop-rs dependency and canonical catalog provider

1 participant