Skip to content

refactor: formal ChainScanner adapter contract for third-party chains… - #190

Closed
kodinaka30-ship-it wants to merge 2 commits into
wraith-protocol:developfrom
kodinaka30-ship-it:feat/issue-176-chain-scanner-adapter
Closed

refactor: formal ChainScanner adapter contract for third-party chains…#190
kodinaka30-ship-it wants to merge 2 commits into
wraith-protocol:developfrom
kodinaka30-ship-it:feat/issue-176-chain-scanner-adapter

Conversation

@kodinaka30-ship-it

Copy link
Copy Markdown

Closes (#176)

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

Hey @kodinaka30-ship-it! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#176 Formal ChainScanner adapter contract for third-party chains Link to this issue

ℹ️ Learn more about linking PRs to issues

@truthixify

Copy link
Copy Markdown
Contributor

Thanks @kodinaka30-ship-it. All four examples jobs fail for one reason, and it is a dropped import rather than anything to do with the adapter design:

src/chains/stellar/scan.ts(95,29): error TS2552: Cannot find name 'hexToBytes'.

Also at lines 99, 417 and 421. develop has this at the top of scan.ts:

import { hexToBytes } from './utils';

The refactor removed it while the four call sites are still there, so the dts build fails for every example. Re-add the import and it should clear all four jobs at once.

Worth noting TypeScript's suggestion in that error, "Did you mean HEX_TO_BYTE?", is a red herring. That is the local lookup table further down the file, not the function you want.

@kodinaka30-ship-it
kodinaka30-ship-it deleted the feat/issue-176-chain-scanner-adapter branch August 28, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants