feat(bench): add governance and stealth-splitter benchmarks - #176
Merged
truthixify merged 1 commit intoAug 27, 2026
Merged
Conversation
…argo.toml - Introduced benchmarks for governance contract functions: propose, vote, and execute. - Added benchmarks for stealth-splitter functions: create_split and fund_split with varying beneficiaries. - Updated Cargo.toml files to include governance and stealth-splitter dependencies and testutils features. - Updated PERF.md with new benchmark results and adjusted Cargo.lock accordingly.
|
@ryzen-xp Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged. Benches for governance and splitter close the last gap the regression gate could not see. Baseline rotated in the same PR as asked @ryzen-xp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withdraw_many(1/10/30),bulk_register/bulk_renew(5/10/20),extend_name_ttl, splittercreate_split/fund_split(5/15/25 beneficiaries), vaultdeposit/claim/refund, and governancepropose/vote/execute.stellar/bench/baseline.jsonand the PERF.md auto-updated block in the same change so the +5%stellar-bench-prgate covers the new rows instead of treating them as unknown.stealth-splitterandgovernanceasrlib+testutilsfor the bench crate only. No contract behavior changes.Why
The +5% instructions gate could not catch regressions on Wave 7 paths (
withdraw_many, bulk names, TTL extend) or secondary contracts (splitter, vault, governance) because those ops were missing fromcollect_rows/ the committed baseline.How it was tested
cargo bench -p wraith-stellar-bench --bench gas -- --format json --out baseline.json— JSON includes every new entrypoint; existing announcer/registry/send/names numbers are unchanged.python3 bench/compare.py bench/baseline.json bench/baseline.json --threshold-pct 5— OK, no per-op regression.cargo fmt --all -- --checkTest plan
Confirm
stellar-bench-pris green (committedbaseline.jsonfallback, or develop artifact + new ops as INFO until this lands).After merge to
develop, confirmstellar-bench-developrewrites the PERF.md current-numbers block with the new rows.Spot-check that no
stellar/**/src/lib.rscontract files are in the diff.Close Bench coverage expansion (withdraw_many, bulk_register, extend_name_ttl, splitter, vault, governance) #162