Batch sender fixed - #172
Closed
stpatrickghost wants to merge 2 commits into
Closed
Conversation
|
@stpatrickghost Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thanks @stpatrickghost. The
Fix: Everything else in the run is green, including the bench jobs, so this should be the only thing between it and a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch-sender was emitting single-topic ANNOUNCE events, which broke
server-side topic-3 view-tag filtering and forced indexers to full-scan
its output. Per-transfer announcements now go through the announcer
contract, the same announcer_client::announce pattern splitter already
uses, so all three sources emit the v2 4-topic layout:
topics: ("announce", scheme_id, view_tag_bucket, metadata_kind)
data: (stealth_address, ephemeral_pub_key, metadata)
view_tag_bucket = metadata[0] as u32.
Issue #62 is an audit-doc correction only. splitter fund_split already
routes through the announcer; no splitter logic change.
Changes
instead. batch_send now takes announcer + scheme_id. Transfer gains
metadata and uses BytesN<32> for the ephemeral key.
matching view-tag subset across announcer, splitter, and batch-sender.
audit-doc finding.
sender, splitter, and batch-sender. No batch-sender-specific
single-topic handler.
link it. No splitter source change.
Test plan
Closes #159