Repository navigation
feat(storage): carry chosen PCP kinds in authenticator transfers - #646
Closed
andreyudentsovottofeller wants to merge 2 commits into
Closed
andreyudentsovottofeller wants to merge 2 commits into
andreyudentsovottofeller wants to merge 2 commits into
Conversation
WIP-109 sends the vault export to the new authenticator, but PCPs stay out of backup exports, so a second device receives the credential and not the sealed package it needs (an NFC document cannot be rebuilt by the backend). Add export_vault_for_transfer(pcp_kinds), which appends the pcp_records of the named kinds to the plaintext export so the host can stay under the WIP-109 size limit, and merge_vault_from_transfer, which adds transferred credentials and any PCP whose id is absent locally. Local PCPs are never replaced; backups keep excluding PCPs; merge_vault_from_backup ignores the table, so the format id is unchanged.
Contributor
Author
|
Not relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP-109 hands the new authenticator a
CredentialStore::export_vault_for_backupexport, and deliberately keepspcp_recordsout of backup exports. So after the vault migration a second device still receives the credential without its sealed package. For the NFC credential that is the document data itself: the backend cannot rebuild it, and the user is sent to re-scan.