Repository navigation
Add download ack tracking to OrbPcpStore - #4
Merged
Merged
Conversation
danielle-tfh
requested review from
andronat,
carlomazzaferro,
eaypek-tfh,
gryaele,
leonanos8,
lorena-boros-tfh,
murph,
mustafakuloglu,
paolodamico,
philsippl and
wojciechsromek
as code owners
October 20, 2026 03:12
Contributor
Author
|
folded back into #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on #2. per-tier download ack, split out of #2 so its easier to review
Notes
mark_ackacks one tier and errors withSignupNotFoundif theres no row - it used to be a silent no-opunacked_tierslists tiers still waiting on an ack, for retry on cold startcargo test,cargo clippy --all-targets -- -D warnings,cargo fmt --checkNote
Low Risk
Localized vault CRUD and query changes with tests; no auth or cross-service behavior in this diff.
Overview
Adds per-tier download acknowledgment on
OrbPcpStore:mark_acksetsis_download_acknowledgedandupdated_atfor a single(signup_id, tier)and returnsSignupNotFoundwhen no row matches (no longer a silent no-op).unacked_tiersscans rows still waiting on ack so cold start can retry pending acks.Integration tests cover tier-scoped acks and the missing-row error path.
Reviewed by Cursor Bugbot for commit a345405. Bugbot is set up for automated code reviews on this repo. Configure here.