Skip to content

Add download ack tracking to OrbPcpStore - #4

Merged
danielle-tfh merged 1 commit into
phase-1a-orb-pcp-storefrom
phase-1a-pcp-ack
Oct 20, 2026
Merged

danielle-tfh merged 1 commit into
phase-1a-orb-pcp-storefrom
phase-1a-pcp-ack

Conversation

@danielle-tfh

@danielle-tfh danielle-tfh commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

stacked on #2. per-tier download ack, split out of #2 so its easier to review

Notes

  • mark_ack acks one tier and errors with SignupNotFound if theres no row - it used to be a silent no-op
  • unacked_tiers lists tiers still waiting on an ack, for retry on cold start
  • ran cargo test, cargo clippy --all-targets -- -D warnings, cargo fmt --check

Note

Low Risk
Localized vault CRUD and query changes with tests; no auth or cross-service behavior in this diff.

Overview
Adds per-tier download acknowledgment on OrbPcpStore: mark_ack sets is_download_acknowledged and updated_at for a single (signup_id, tier) and returns SignupNotFound when no row matches (no longer a silent no-op). unacked_tiers scans rows still waiting on ack so cold start can retry pending acks.

Integration tests cover tier-scoped acks and the missing-row error path.

Reviewed by Cursor Bugbot for commit a345405. Bugbot is set up for automated code reviews on this repo. Configure here.

@danielle-tfh
danielle-tfh merged commit a345405 into phase-1a-orb-pcp-store Oct 20, 2026
4 checks passed
@danielle-tfh

Copy link
Copy Markdown
Contributor Author

folded back into #2

@danielle-tfh
danielle-tfh deleted the phase-1a-pcp-ack branch October 20, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant