Repository navigation
chore: pin node - #363
chore: pin node#363
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Current version of PR was reviewed by /review-bugbot on Oct 22, 18:55 UTC. It flagged 0 findings. Bugbot on commit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5747a2c1b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "type": "module", | ||
| "engines": { | ||
| "node": "24.x" | ||
| "node": "24.22.1" |
There was a problem hiding this comment.
Keep the Vercel runtime on a major-version range
When Vercel automatically rolls Node 24 to its next patch, this exact engine stops matching the runtime used by the deployed Next.js example, and the corepack pnpm install command in vercel.json will fail with an unsupported-engine error before the build. Vercel only makes major versions selectable and explicitly warns for major.minor.patch engine values, so retain 24.x here and pin local/CI tooling separately. See Vercel's runtime documentation and the corresponding Vercel version-selection code.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in f234ac4. Restored 24.x for the Vercel example; CI and release workflows retain exact security-patch pins. Verified the range accepts Node 24 patch/minor updates and rejects other majors, and the example's frozen-lockfile install passes on Node 24.22.1.
Note
Low Risk
Workflow-only Node version pins; initiate-release upgrades from Node 18 to 22.23.4, which could surface script compatibility issues but does not change application runtime code.
Overview
Pins exact Node.js patch versions across GitHub Actions so CI, conformance, release initiation, and npm publish jobs no longer float on major-only labels like
"22"or"24".Build and test workflows (
ci.yml,js-conformance.ymlconformance/hermes/packages build steps) now use 22.23.4. The package consumption matrix tests Node 18 (unchanged), 22.23.4, and 24.22.1 instead of"22"/"24", and Playwright/portable runtime steps key offmatrix.node == '22.23.4'.Release initiation (
initiate-release.yml) moves from Node 18 to 22.23.4 for version-bump scripts. Publish workflows (publish-js.yml,publish-react.yml,publish-server.yml) pin the publish runner to 24.22.1.Reviewed by Cursor Bugbot for commit f234ac4. Bugbot is set up for automated code reviews on this repo. Configure here.