Repository navigation
fix(sdk): add explicit session creation flags - #362
Takaros999 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ee2ddc102
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.environment = environment | ||
| self.connectUrlMode = connectUrlMode | ||
| self.sessionId = sessionId | ||
| self.createSession = createSession |
There was a problem hiding this comment.
Normalize the legacy Swift alias into createSession
When an existing caller constructs IDKitRequestConfig(..., sessionId: "create"), this property remains at its default false, even though native prioritizes sessionId and sends "create". Any UI, logging, or control flow that reads the newly public config.createSession therefore reports the opposite of the request's actual behavior for the supported legacy alias; normalize the stored value in the initializer or derive it from sessionId, as the Kotlin wrapper does.
Useful? React with 👍 / 👎.
Uniqueness requests expose
session_ideven though the only accepted value is"create". Addcreate_session: truein JS/React andcreateSession: truein Swift/Kotlin, translating them to the existing protocol field.The published string option remains supported as a deprecated alias. Default requests stay unchanged, invalid aliases still fail validation, and Kotlin keeps its existing constructor and
copybinary signatures. The preview's Create Session checkbox uses the new flag.Documentation: developer-docs #215.
Validation: