Repository navigation
feat: add usage skill - #17
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67aedad3bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Your wallet | Match `chainId` | Use `type` | | ||
| |--------------------|----------------------|-------------| | ||
| | EVM EOA | `eip155:*` | `eip191` | | ||
| | EVM Smart Contract | `eip155:*` | `eip1271` | | ||
|
|
There was a problem hiding this comment.
This skill advertises SIWS/Solana support, but the wallet mapping table only includes eip191 and eip1271. In the implementation, Solana challenges use solana:* with ed25519 (agentkit/src/declare.ts and agentkit/src/types.ts), so an agent following the current table cannot choose a valid type for Solana and will fail authentication on Solana-protected endpoints.
Useful? React with 👍 / 👎.
| type: "eip191", // "eip191" for EOA, "eip1271" for SCW | ||
| signature: signature, // hex string from signing |
There was a problem hiding this comment.
The Step 4 example labels signature as a hex string, but Solana verification decodes payload.signature as Base58 (agentkit/src/verify.ts), not hex. For any solana:* flow this instruction leads directly to Invalid Base58 encoding and a hard auth failure, so the guidance should be chain-specific (hex for EVM, Base58 for Solana).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
dont support solana
* chore: bump @worldcoin/agentkit to 0.1.6 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * clean up --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Add usage skill