Repository navigation
fix(ci): stop deploy.yml failing on every push, dry-run deploy mechanics (Phase 14) - #24
Merged
Merged
Conversation
…chanics (Phase 14) deploy.yml (FastAPI Cloud) has failed on every single push to master since this repo's first one -- invisible to gh pr checks because a push-triggered workflow never appears there. Root cause: `bun run --filter frontend build`, but the workspace package has been `botpit-frontend` since the Phase 9.5 rebrand. Fixed the bug and changed the trigger to workflow_dispatch (no FASTAPI_CLOUD_TOKEN exists yet -- DECISIONS.md §1, no server), matching deploy-docker-compose.yml's own already-correct pattern. Dry-ran the compose-based deploy mechanics for real: config+build clean, and the prepare-database step against a fresh throwaway Postgres under FASTAPI_ENV=production with real secrets -- full migration chain applies cleanly, superuser seeds correctly, Settings correctly refuses dev-placeholder secrets outside development. Also adapted two template-org leftovers explicitly deferred to this phase in Phase 9.7's own write-up (deploy*.yml's/zizmor.yml's always-constant github.repository[_owner] conditionals), and fixed a stale DECISIONS.md cross-reference to a deployment doc that never existed at that path. Claude-Session: https://claude.ai/code/session_01UbiPa1rKCyqhqufgwJWkeW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/deploy.yml(FastAPI Cloud) triggers onpush: branches: [master], invisible togh pr checks(only shows PR status checks, not post-merge push-triggered workflows). It has failed on every single push to master since this repo's first one. Root cause:bun run --filter frontend build-- the workspace package has beenbotpit-frontendsince the Phase 9.5 rebrand, notfrontend.workflow_dispatchonly, matchingdeploy-docker-compose.yml's own already-correct pattern -- noFASTAPI_CLOUD_TOKENexists yet (DECISIONS.md §1: no server bought until local dev is complete), so even fixed it would still correctly fail at the final deploy step. No point auto-firing and failing on every merge for a deploy nobody's asking it to attempt.compose.yml+compose.deploy.yml'sconfig/buildclean; the "prepare database" step run directly against a fresh throwaway Postgres underFASTAPI_ENV=productionwith real secrets -- full migration chain applies cleanly, superuser seeds correctly, andSettingscorrectly refuses dev-placeholder secrets outsidedevelopment(confirmed the guard works, not routed around).docs/development/ci-cd-and-docker.md):deploy*.yml's andzizmor.yml's always-constantgithub.repository/repository_ownerconditionals, replaced with what they always evaluate to for this repo.issue-manager,bump-pre-commit-hooks,add-to-project) via run history -- correctly inert (skipped, never failed), left alone per Phase 9.5/9.6 precedent.DECISIONS.mdcross-reference todocs/deployment.md(never existed) -- the real, already-thorough doc isdocs/deployment/.No application code or tests changed -- CI workflow YAML and docs only.
Test plan
prek run --all-filesclean, includingzizmor(GH Actions security linter) against every edited workflowdocker compose -f compose.yml -f compose.deploy.yml config/buildverified locallyClaude-Session: https://claude.ai/code/session_01UbiPa1rKCyqhqufgwJWkeW