[wegamekinglc]

Summary

Follow-up to a full-codebase review along three axes (DRY, unit-test coverage, documentation consistency). Four logical commits:

1. fix(frontend): Curve Lab build-run stepper states — NON_TERMINAL_BUILD_STATES listed ADMITTED/RUNNING, which the backend never emits; a healthy SOLVING build rendered as failed in the stepper. Now uses the real transient set (QUEUED/RESOLVING_DEPENDENCIES/SOLVING).

2. docs: README + docstrings — document the >=3.13,<3.14 Python cap (cp313-only dal-python wheels), fix the nonexistent "web-quality CI job" reference, fix the directory tree (migrations/, curve_risk.py, src/curves/), and correct stale docstrings (value_trade, "market endpoints") plus the store_dependency return annotation.

3. refactor(backend): error handling + canonical rules —

   • App-level exception handlers for CurveLabLifecycleError / QuoteCanonicalizationError / NotFoundError / ConflictError replace 34 copy-pasted try/except blocks across the routers. Trade creation keeps its distinct NotFoundError → 422 mapping.
   • canonical_json.py is now the single canonical-byte implementation, unified on UTF-8 (matching the persisted canonical_error_utf8 contract); the calibration-side duplicate is gone. Pure-ASCII payloads hash identically either way; non-ASCII Curve Lab fingerprints computed before this change will not match recomputation.
   • New instrument_order.py: one native-name map and one canonical (maturity, start, native_name) ordering shared by admission and the gateway (previously five copies), so the persisted calibration_index mapping cannot drift.

4. test(backend): shared helpers + coverage —

   • api_helpers.py / curve_lab_helpers.py remove triplicated helpers across six test files.
   • test_store_contract.py: the same behavioral suite runs against both Store and DbStore (delete guards, cascade, CAS publish idempotency, restart reconciliation) — first behavioral coverage for the in-memory store.
   • test_dal_gateway_native_paths.py: a dedicated recording fake dal covers the single-curve spec builder, all six instrument kinds, and the price_curve_lab_trades error branches — paths the shared fake never reaches.
   • Boundary pins: MATRIX_DIMENSION_EXCEEDED rejection, malformed If-Match/runtime-manifest 422s, build/import 429 queue exhaustion, portfolio 404s.

Verification

• Backend: 491 passed (up from 451), 2 native-marked passed, ruff check app/ tests/ clean.
• Frontend: 101 vitest tests passed, npm run build (type-check) clean.

Known follow-ups (deliberately out of scope)

• Admission-vs-fallback knot/free-parameter count math (_declaration_counts vs _fallback_storage_nodes) is not byte-equivalent today (LOG_DISCOUNT anchor semantics differ); merging needs a contract decision first.
• No coverage tooling installed yet (pytest-cov, @vitest/coverage-v8).
• Frontend CRUD pages and Curve Lab risk/import flows remain e2e-only.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 101 complexity · -7 duplication

Metric	Results
Complexity	101
Duplication	-7

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[Copilot]

Pull request overview

This PR follows up on a codebase-wide DRY / test-coverage / documentation-consistency review by aligning frontend Curve Lab stepper state handling with backend-emitted states, consolidating backend canonicalization + instrument-order rules into shared utilities, centralizing backend exception handling, and expanding/refactoring test coverage via shared helpers and new contract/path suites.

Changes:

• Frontend: fix Curve Lab build stepper transient-state handling (and update unit tests) to match backend state machine.
• Backend: centralize exception mapping in app-level handlers; unify canonical JSON bytes/hash logic; consolidate calibration instrument ordering into a shared module.
• Tests: add Store vs DbStore behavioral contract suite, add native DAL gateway path coverage, and DRY common API/Curve Lab helpers.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
README.md	Updates runtime/docs details (Python cap, CI naming, tree layout).
frontend/tests/unit/curve_lab_workspace.test.tsx	Aligns workspace test fixtures with new transient build state.
frontend/tests/unit/curve_builder_utils.test.ts	Adds coverage for additional transient/terminal build states.
frontend/src/curves/curveBuilderUtils.ts	Updates NON_TERMINAL_BUILD_STATES to backend-emitted transient states.
backend/tests/test_valuation_failures.py	DRYs API test setup/polling via shared helpers.
backend/tests/test_store_contract.py	New behavioral contract suite covering Store + DbStore semantics.
backend/tests/test_eval_date.py	DRYs API setup/polling via shared helpers; removes local duplicates.
backend/tests/test_dal_gateway_native_paths.py	New tests covering native DalGateway request-building/error branches.
backend/tests/test_curve_lab_risk_api.py	Replaces duplicated helpers/constants with shared Curve Lab helpers.
backend/tests/test_curve_lab_lifecycle_api.py	Replaces duplicated helpers with shared Curve Lab helpers; adds new boundary tests.
backend/tests/test_curve_lab_build_modes.py	Imports shared DISCOUNT_KEY constant to avoid drift.
backend/tests/test_curve_lab_api.py	Updates canonical JSON expectation to UTF-8 (non-ASCII preserved).
backend/tests/test_calibration_acceptance_boundaries.py	Adds boundary test for matrix dimension pre-admission rejection.
backend/tests/test_api.py	DRYs valuation polling and entity creation with shared helpers.
backend/tests/curve_lab_helpers.py	New shared helpers/constants for Curve Lab API job polling/completion.
backend/tests/curve_lab_compiled_fixing_admission_subprocess.py	Adjusts sys.path/imports to use shared job polling helper.
backend/tests/api_helpers.py	New shared helpers for product/model/trade/portfolio valuation API tests.
backend/app/services/valuation.py	Docstring consistency update for blocking valuation paths.
backend/app/services/store.py	Uses canonical JSON utility as single source of truth.
backend/app/services/instrument_order.py	New shared canonical instrument ordering + native-name mapping.
backend/app/services/db/store_db.py	Switches to canonical JSON utility implementation.
backend/app/services/dal_gateway.py	Uses shared instrument-ordering utilities; removes duplicated mapping/sorting.
backend/app/services/canonical_json.py	Canonical JSON bytes now UTF-8, non-ASCII preserved; shared hashing utility.
backend/app/services/calibrations.py	Reuses canonical JSON + shared instrument ordering; removes duplicated logic.
backend/app/routers/trades.py	Removes per-route NotFound try/except in favor of app-level handlers (except trade create mapping).
backend/app/routers/system.py	Removes per-route NotFound try/except in favor of app-level handlers.
backend/app/routers/products.py	Removes per-route NotFound/Conflict try/except in favor of app-level handlers.
backend/app/routers/portfolios.py	Removes per-route NotFound try/except in favor of app-level handlers.
backend/app/routers/models.py	Removes per-route NotFound/Conflict try/except in favor of app-level handlers.
backend/app/routers/curve_lab.py	Removes per-route lifecycle/quote error wrapping; relies on app-level handlers.
backend/app/main.py	Adds centralized exception handlers for lifecycle/canonicalization/not-found/conflict.
backend/app/dependencies.py	Updates store dependency type to StoreProtocol for interface-based routing.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.