fix(updates): show the update prompt where it can be seen - #29
Merged
Merged
Conversation
The update banner was fixed to the bottom-right of the main window's DOM,
which the native tab webview is drawn over. With any page open it was
invisible, so installed copies never showed an available update.
- The prompt is now a toolbar pill ("Update to x.y.z"), which no page
can cover: shows download progress, then Restart, and says when the
install failed instead of failing silently.
- Settings gains a "Check for updates" button with a visible result
(up to date / available / couldn't reach GitHub).
- Update state lives in stores/updates.ts, shared by both.
Verified in a dev build posing as 0.13.0: the pill appeared for 0.13.1
and the Settings check reported it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After publishing v0.13.1, installed 0.13.0 copies never showed the update. The check itself worked — the updater feed returns 0.13.1, signed for all three installer types — but the banner was fixed to the bottom-right of the main window's DOM. The native tab webview is drawn over that area, so with any page open the banner was invisible. (Same class of bug as
window.confirm()in CLAUDE.md.)Fix
UpdateButton): "Update to x.y.z" next to the bookmark star, where no page can cover it. Shows download progress, then Restart, and "Update failed · retry" instead of a toast nobody could see.stores/updates.ts;UpdateBanner.tsxremoved. Still one automatic check per launch, and nothing downloads until the user clicks.Testing
pnpm check-types,pnpm lint,pnpm test(80),pnpm knipNote for existing users
Copies on 0.13.0/0.13.1 still have the old banner. It is visible on a blank new tab (Ctrl+T), so the release notes for the next version should mention that.