Read the sides in mirrored order, not in the same direction on both - #246
Draft
webdevred wants to merge 2 commits into
Draft
Read the sides in mirrored order, not in the same direction on both#246webdevred wants to merge 2 commits into
webdevred wants to merge 2 commits into
Conversation
X is compared as written, and the sides have opposite signs, so the left side is walked from the centre outwards and the right side from the outside in. The fixture holds one mirrored pair of columns, and the spec says only that the two sides agree, not which way they run, so it cannot be satisfied by picking a direction. The two pending ones say what the sort-axes key has to do once it exists, since a config naming it is accepted and ignored today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only, all of them failing or pending. Part of #243.
Both sides of a car hold the same shape mirrored, so the order the transform writes them in should mirror too. It does not. X is compared as written, in the tie break and in the column pass from #235, and the sides have opposite signs, so the left side is walked from the centre outwards while the right side is walked from the outside in. The right side is the one that already does what the jbeam maintainer asked for, by accident.
The fixture holds one mirrored pair of columns at a single station, so nothing but the column order can decide the outcome. The spec says only that the two sides agree, not which way they run, so it cannot be satisfied by picking a direction, and the direction itself is still the maintainer's call.
Worth knowing before implementing it: comparing the distance from the centre line instead, outermost first, turns this spec green and changes eight of the existing fixture comparisons, both configs of
frameandsuspensionand their fixed-point checks. It also contradicts one spec that came in with #244, which pins the current inner-first order of a grid, so that expectation moves with the same change. This is not a two line fix with no consequences, and the diff will show it.The two pending specs describe the
sort-axeskey. A config naming it today is parsed and thrown away, so the file sorts by the default axes without saying so, and a repeated or short list is not refused where it is written.