-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update dependency commander to v15 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ | |
| "@wave-av/sdk": "^2.0.11", | ||
| "chalk": "^5.4.1", | ||
| "cli-table3": "^0.6.5", | ||
| "commander": "^13.1.0", | ||
| "commander": "^15.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Changelog not updated for a user-visible dependency upgrade The major upgrade of the command-line parser ( Repo rule reference
Prompt for agentsWas this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Help output override relies on
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| "conf": "^13.1.0", | ||
| "inquirer": "^12.3.2", | ||
| "keytar": "^7.9.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 CLI declares support for Node 18 but the upgraded argument parser no longer runs there
The dependency on the command-line parser is raised to a major version that dropped Node 18 support (
"commander": "^15.0.0"atpackage.json:61) while the package still advertises Node 18 compatibility, so users on Node 18 get install-time engine errors or a broken CLI.Impact: Anyone installing the CLI on Node 18 sees engine warnings/failures and may end up with an unusable command-line tool.
Engine range vs. commander major bump
package.json:49-51still declares"node": ">=18.0.0". Commander dropped Node 18 in its v14 major (engines^20.19.0 || >=22.12.0), and v15 continues to require a modern Node. npm will emit EBADENGINE for the transitive requirement, and if it installs anyway, the CLI entry (src/index.ts:1-6, which callscommander'sparseAsync) may fail at runtime on Node 18. Theengines.nodefield should be raised to match commander's supported range.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.