-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update dependency chalk to v6 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ | |
| }, | ||
| "dependencies": { | ||
| "@wave-av/sdk": "^2.0.11", | ||
| "chalk": "^5.4.1", | ||
| "chalk": "^6.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π‘ Changelog not updated for the dependency upgrade The upgrade of the color library ( Repo rule reference
Prompt for agentsWas this helpful? React with π or π to provide feedback. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π chalk API surface used is limited to stable helpers All usage in Was this helpful? React with π or π to provide feedback. |
||
| "cli-table3": "^0.6.5", | ||
| "commander": "^13.1.0", | ||
| "conf": "^13.1.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π΄ CLI can break for users on Node 18 after the color-library upgrade
The color library is upgraded to a major version that no longer supports Node 18 (
"chalk": "^6.0.0"atpackage.json:59) while the package still advertises Node 18 as supported, so users on Node 18 get engine warnings and a CLI that can fail to run.Impact: People running the CLI on Node 18 may see install-time engine errors or runtime failures instead of a working tool.
Engine range mismatch between dependency and declared support
package.json:49-51still declares"engines": { "node": ">=18.0.0" }, but chalk 6 dropped support for Node 18 (its ownenginesrequires Node 20+). With npm's defaultengine-strict=false, installation proceeds with anEBADENGINEwarning, and any use of chalk (used broadly, e.g.src/commands/stream/index.ts:2) risks failing on Node 18. Either raise the package'sengines.node(and CI/docs) to match chalk 6, or stay on chalk 5.Prompt for agents
Was this helpful? React with π or π to provide feedback.