chore(deps): update dependency chalk to v6 - #27
Conversation
|
PR author is in the excluded authors list. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| "dependencies": { | ||
| "@wave-av/sdk": "^2.0.11", | ||
| "chalk": "^5.4.1", | ||
| "chalk": "^6.0.0", |
There was a problem hiding this comment.
🔴 CLI can break for users on Node 18 after the color-library upgrade
The color library is upgraded to a major version that no longer supports Node 18 ("chalk": "^6.0.0" at package.json:59) while the package still advertises Node 18 as supported, so users on Node 18 get engine warnings and a CLI that can fail to run.
Impact: People running the CLI on Node 18 may see install-time engine errors or runtime failures instead of a working tool.
Engine range mismatch between dependency and declared support
package.json:49-51 still declares "engines": { "node": ">=18.0.0" }, but chalk 6 dropped support for Node 18 (its own engines requires Node 20+). With npm's default engine-strict=false, installation proceeds with an EBADENGINE warning, and any use of chalk (used broadly, e.g. src/commands/stream/index.ts:2) risks failing on Node 18. Either raise the package's engines.node (and CI/docs) to match chalk 6, or stay on chalk 5.
Prompt for agents
package.json bumps chalk to ^6.0.0, whose own engines field requires Node 20+, while this package still declares engines.node ">=18.0.0" (package.json:49-51). Decide whether to raise the supported Node floor (updating engines, README/docs, and any CI node-version matrix) or to keep chalk on the 5.x line so Node 18 remains genuinely supported.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "dependencies": { | ||
| "@wave-av/sdk": "^2.0.11", | ||
| "chalk": "^5.4.1", | ||
| "chalk": "^6.0.0", |
There was a problem hiding this comment.
🟡 Changelog not updated for the dependency upgrade
The upgrade of the color library ("chalk": "^6.0.0" at package.json:59) ships without any note added to the changelog's Unreleased section, so the repo's contribution rule about recording user-facing changes is not met.
Impact: Users and maintainers get no record that the tool's supported runtime/dependencies changed.
Repo rule reference
AGENTS.md requires: "Conventional Commit titles; update CHANGELOG.md (Unreleased) for user-facing changes." The ## [Unreleased] section in CHANGELOG.md:7 is still empty, while this change raises the effective minimum Node version for end users.
Prompt for agents
Per AGENTS.md, user-facing changes must be recorded under the Unreleased heading in CHANGELOG.md. Add an entry describing the chalk 6 upgrade and any resulting change in the minimum supported Node version.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "dependencies": { | ||
| "@wave-av/sdk": "^2.0.11", | ||
| "chalk": "^5.4.1", | ||
| "chalk": "^6.0.0", |
There was a problem hiding this comment.
🔍 chalk API surface used is limited to stable helpers
All usage in src/ is limited to chalk.green/red/yellow/bold/dim/cyan-style helpers (e.g. src/commands/stream/index.ts:23, src/commands/doctor/index.ts:115), which remain unchanged in chalk 6, so no code changes are required beyond the runtime/engine consideration. There is no lockfile committed, so the actual resolved chalk version (and its engine constraint) cannot be verified from the repo — worth confirming during install/CI.
Was this helpful? React with 👍 or 👎 to provide feedback.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Risk: medium. Left a non-blocking comment because Cursor Security Agent skipped, so it cannot be used as an approval signal; Cursor Bugbot was not present. Assigned yakimoto for human review of this chalk v6 major bump.
Sent by Cursor Approval Agent: Pull Request Router and Approver
ApprovabilityVerdict: Needs human review This dependency update from chalk 5 to chalk 6 introduces a Node.js compatibility issue: chalk 6 requires Node 20+, but the package declares support for Node 18+. The unresolved critical review comment identifies this breaking change, and the modified file (package.json) is owned by wave-av/core-team, not the PR author. You can customize Macroscope's approvability policy. Learn more. |
This PR contains the following updates:
^5.4.1→^6.0.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
chalk/chalk (chalk)
v6.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.