Skip to content

Require Codex notification plugin 0.4.3 #16368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeywangzr merged 1 commit into from
Oct 15, 2026
Merged

Require Codex notification plugin 0.4.3 #16368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/terminal/cli_agent_sessions/plugin_manager/codex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const CODEX_CONFIG_DIR: &str = ".codex";
const CODEX_HOME_ENV: &str = "CODEX_HOME";

// Keep in sync with the plugin version in warpdotdev/codex-warp.
const MINIMUM_PLUGIN_VERSION: &str = "0.4.2";
const MINIMUM_PLUGIN_VERSION: &str = "0.4.3";

@warp-for-oss warp-for-oss Bot Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] The PR description says 0.4.3 is still unpublished; merging this floor first can make update flows require a plugin version that the marketplace cannot satisfy. Keep this held until the companion plugin release is published.

// Keep in sync with the orchestration plugin version in warpdotdev/codex-warp.
const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "0.4.1";

Expand Down
4 changes: 2 additions & 2 deletions app/src/terminal/cli_agent_sessions/plugin_manager/codex_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ fn minimum_version() {
let _guard = FeatureFlag::CodexPlugin.override_enabled(true);
assert_eq!(
CodexPluginManager::new(None, None, None).minimum_plugin_version(),
"0.4.2"
MINIMUM_PLUGIN_VERSION

@warp-for-oss warp-for-oss Bot Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 [SUGGESTION] This makes the test mirror the implementation constant instead of pinning the release floor; keep the literal version so an accidental minimum bump or downgrade is visible in review.

Suggested change
MINIMUM_PLUGIN_VERSION
"0.4.3"

@seemeroland seemeroland Oct 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem valid, but I kind of think this test is useless and we should delete it

);
}

Expand Down Expand Up @@ -225,7 +225,7 @@ fn platform_plugin_version_is_not_current_when_cache_outdated() {
fn needs_update_true_when_enabled_and_version_outdated() {
let dir = tempfile::tempdir().unwrap();
write_plugin_config(dir.path(), super::PLUGIN_KEY, true);
write_cache_manifest(dir.path(), super::PLUGIN_NAME, "0.4.1");
write_cache_manifest(dir.path(), super::PLUGIN_NAME, "0.4.2");

assert!(super::plugin_needs_update(
dir.path(),
Expand Down
Loading