Skip to content

Fix Windows input identity and private cache protection for 0.2.0 - #44

Merged
wangjohn merged 9 commits into
mainfrom
codex/release-020-windows
Oct 5, 2026
Merged

wangjohn merged 9 commits into
mainfrom
codex/release-020-windows

Conversation

@wangjohn

@wangjohn wangjohn commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

What changed

Prepare Windows release readiness for 0.2.0. Canonical relative document IDs, case-sensitive component ordering and drive-aware home privacy restore portable corpus behavior while preserving Linux/macOS ordering. Cache descriptions close SQLite connections and escape URI characters correctly.

Native cache ACLs restrict owned directories/database/sidecars to the current user, SYSTEM and Administrators. Verification reads numeric SIDs/access masks from native ACEs, checks directory inheritance, and refuses unsupported/denied ACLs, reparse points, linked ancestors and hard-linked cache files. Caller parents and unrelated existing children are preserved. Protection failure adds CACHE_UNAVAILABLE while measurement continues.

Select PERSIST journaling before auto_vacuum initialization writes. This prevents SQLITE_IOERR_DELETE when Windows cannot delete a journal another live PERSIST connection holds; cold/warm builds and shared-process caches retain their contract.

No statistical algorithms, calibration, report version8.1, package version0.2.0, runtime dependencies, benchmark margins/allowances or deferred WP1/WP10 changes.

Baseline and review dispositions

Original actual-main Windows baseline cbae129:14 failed,825 passed,46 skipped. No baseline failure was exempted from current modified scope.

  • W01: fixture explicitly writes UTF8; edit/duplicate pairing unchanged.
  • W02/W04/W13: canonical nested relative IDs match saved sources.
  • W03/W05: native warm-cache/new-document reuse repaired by selecting PERSIST before initialization writes; exact hit/count/byte assertions retained.
  • W06: canonical IDs preserve unique document names under all tested hash seeds.
  • W07: actual Windows private ACL checks replace POSIX-only mode assertions on Windows; POSIX assertions retained.
  • W08: describe closes handles on success/failure and uses escaped absolute file URI; native describe/clear/shared-process coverage passes.
  • W09: unavailable-command test injects access denial portably; real damaged-cache test uses Windows read-only file protection and POSIX directory protection. Damaged bytes, warning and exact numerical report assertions retained.
  • W10/W11: native USERPROFILE fixture and anchored home recognition preserve user-name privacy across drives.
  • W12: nonexistent inferred named homes return the existing not_found library error.
  • W14: tuple-of-components ordering fixes Windows case folding and preserves base POSIX nested-prefix order.

Independent repair pass1 additionally fixed SDDL alias rejection, ignored deny ACEs/noninheriting parent acceptance, hard-link and linked-ancestor guards, journal deletion and POSIX ordering compatibility. Meaningful portable/native regressions retained. Fresh reviewer2 independently verified all prior dispositions, then repaired W2-THREAD-01: close now stops and joins failed cache writers too, so protection/read/write failure cannot orphan an idle daemon or retain its connection. Three meaningful failure-lifetime regressions failed unfixed and passed fixed. Fresh independent reviewer3 assessed the complete current diff, verified every prior disposition with independent probes and exact current native CI, and found no supported new defect. Source remained unchanged; final independent verification is complete.

Actual validation

Current head 96ce2727e6056efb81b650782818f3e9a6677610, actual target/merge-base cbae1295c757e22c20369aaf2b192f8d3fa1f225.

  • Exact CI 37274001036: all 11 jobs passed, testing merge 65e67f9 of this head into the recorded base. Required full Windows suite: 870 passed / 46 skipped. Native platform regressions: 206 passed plus both snapshots. Python 3.11–3.14, macOS modes, no-syntax, package and enforcing benchmark jobs passed.
  • Local full check: 906 passed / 10 skipped; lint, format and types passed. Demo passed. Fresh installed wheel/sdist/setup/syntax/demo validation passed; unpacked sdist: 905 passed / 11 skipped. Initial distribution attempt failed sandbox DNS; retained, then isolated download-enabled retry passed. Five native Windows cases are unavailable locally and covered by the actual native CI, not POSIX permission substitutes.
  • Root-coordinated exclusive repeat-5 benchmark compared frozen head against actual cbae base with unchanged gates: build CPU 0.997x, RSS 0.998x, profile size 1.000x, score CPU 0.977x, RSS 0.997x; all passed. Advisory absolute build wall target was exceeded (2.10s versus 1.60s), recorded honestly. Exact-head CI benchmark also passed all five unchanged gates.
  • Windows advisory status was removed at prior 8161745 only after the complete native suite genuinely passed. Current full Windows remains required and passes.

Fresh independent pass3 is complete with no source changes or unresolved supported finding. The worker made no formal approval, merge or publication; root retains guarded merge and publication authority. Prior failed native and local attempts remain in factual review reports.

@wangjohn
wangjohn marked this pull request as ready for review October 5, 2026 07:03
@wangjohn
wangjohn merged commit fbafabb into main Oct 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant