Repository navigation
fix(occt): treat a broken wasm function table as a dead heap - #880
Merged
Merged
Conversation
Signature mismatch was stored as an ordinary feature failure, so the worker stayed up and the viewer never got a mesh. Classify it as poison so recompute resets and retries once. If that retry is still poisoned, throw so the host recycles the process.
w1ne
enabled auto-merge
October 7, 2026 09:56
Returning a per-feature diagnostic kept the dead worker in service. meshFeaturesPerFeature stays under the line limit; the throw is what the host recycles on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
null function/function signature mismatchas a dead OCCT wasm heap.Test
npx vitest run src/kernel/backends/occt/occtException.test.ts— 18 passed.npx eslinton the three changed files — clean.