Repository navigation
dbserver: name 0x3007 as set filter on/off, not media info - #94
Merged
Merged
Conversation
Decks send 0x3007 before each root menu request, and we labelled it "mount/media info". link-spec's static analysis shows it is CMD_SET_FILTER_ONOFF: rekordbox dispatches it to PSvDBMain::OnFilterCmd as the first of its filter commands (0x3007 to 0x3407), and XDJ-RR firmware sends it from dbcl_SetFilterOnOff. Rename the handler, document the evidence, and log the request's arguments so a deck session shows what the deck asks for. The reply is unchanged: rekordbox's has not been captured, and decks accept our plain success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Decks send dbserver request
0x3007before each root menu request (0x1000); a CDJ-2000NXS2 log shows it on every browse. We have handled it since the initial commit under the label "mount/media info", with no evidence behind the name.link-spec's static analysis says otherwise. rekordbox dispatches
0x3007toPSvDBMain::OnFilterCmdasCMD_SET_FILTER_ONOFF, the first of its five filter commands (0x3007to0x3407in0x100steps: on/off, get property, set property, set My Tag, add My Tag item). On the deck side, XDJ-RR firmware sends it from a client wrapper nameddbcl_SetFilterOnOff. So the deck turns rekordbox's browse filter on or off before opening the root menu.handleSetFilterOnOff, with a comment pointing at the link-spec evidence.0x3007has not been captured (link-spec only has the dispatch entry, and no conformance golden sends it), and decks accept our plain success[0x3007, 0].Hardware testing
Checklist
go build ./...,go vet ./..., andgo test ./...passgofmt -l .is cleanGPL-3.0-or-later)